Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Base Url config not used #90

Closed
mmarquezs opened this issue Oct 9, 2016 · 12 comments
Closed

Bug report: Base Url config not used #90

mmarquezs opened this issue Oct 9, 2016 · 12 comments

Comments

@mmarquezs
Copy link
Contributor

mmarquezs commented Oct 9, 2016

Issue experienced

I tried to change the base url, so I can easily make it work with a reverse proxy but it doesn't seems to work.

Steps to reproduce

I changed the config.json, the global part :

  "global": {
    "apikey": "API",
    "baseurl": "/cardigann"
  },

(I also tried "cardigann" and "/cardigann/")

After that I restarted the service but it seems it doesn't use that setting or maybe I'm setting it wrong.

Cardigann version (in the footer, or via cardigann --version)

1.8.5

@lxt2
Copy link
Contributor

lxt2 commented Oct 9, 2016

Interesting, what made you think that there was a base url config? It's something I'd be happy to add, but it doesn't exist at the minute. The XHR requests that the javascript side makes to the server side might present some problems too, but shouldn't be too bad.

@mmarquezs
Copy link
Contributor Author

Well it's a common feature to have sonarr,couchpotato,jacket,.. have it and I saw here baseurl together with apikey and passphrase and I tought it had the config ( I didn't look a lot on the code obviously):

https://github.com/cardigann/cardigann/blob/master/server/handler.go

@lxt2
Copy link
Contributor

lxt2 commented Oct 10, 2016

Good point, it does look like I implemented part of it :)

@f-vt
Copy link

f-vt commented Dec 4, 2016

Yeah it will be perfect if implemented,

I use some nginx revese proxy in subdirs of my "dl" site (/sonarr; /couchpotato ; etc...) and It's mandatory for me to have this option to no have to create an other site only for cardigann...

Thanks 👍

@onedr0p
Copy link

onedr0p commented Jan 22, 2017

Please add this :)

@kkuhle
Copy link

kkuhle commented Jan 23, 2017

It would be great to see this implemented!

@tdharris
Copy link

I would really love to see this implemented! It would be perfect!

@JoeStratton
Copy link

I would like this as well!

@furgoose
Copy link

Is there any progress on this?

@ghost
Copy link

ghost commented Apr 18, 2017

Yes, if you can add that. it will be perfect ;)

@lxt2
Copy link
Contributor

lxt2 commented Sep 29, 2017

I added this recently, you can use cardigann server --prefix /blah

@lxt2 lxt2 closed this as completed Sep 29, 2017
@teotikalki
Copy link

What about the respecting the baseurl directive? The '--prefix' flag is great and all but isn't ideal for configuration as a service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants