Checksum selection

pkg/ghet/download/plan.go

@@ -3,7 +3,6 @@ package download
 import (
 	"context"
 	"fmt"
-	"strings"
 
 	pkggithub "github.com/cardil/ghet/pkg/github"
 	githubapi "github.com/cardil/ghet/pkg/github/api"
@@ -54,7 +53,7 @@ func CreatePlan(ctx context.Context, args Args) (*Plan, error) {
 	log.WithFields(slog.Fields{"assets": namesOf(rr.Assets)}).
 		Debug("Checking assets")
 	for _, asset := range rr.Assets {
-		if assetMatches(asset, args) {
+		if args.Asset.Matches(asset.GetName()) {
 			a := githubapi.Asset{
 				ID:          asset.GetID(),
 				Name:        asset.GetName(),
@@ -144,14 +143,3 @@ func fetchRelease(
 	}
 	return rr, r, nil
 }
-
-func assetMatches(asset *github.ReleaseAsset, args Args) bool {
-	name := strings.ToLower(asset.GetName())
-	basename := strings.ToLower(args.Asset.BaseName)
-	coords := strings.TrimPrefix(name, basename)
-	return strings.Contains(name, args.Checksums.ToString()) ||
-		(strings.HasPrefix(name, basename) &&
-			args.Architecture.Matches(coords) &&
-			args.OperatingSystem.Matches(coords))
-
-}

pkg/ghet/download/plan_test.go

@@ -40,14 +40,6 @@ func TestCreatePlan(t *testing.T) {
 			}, {
 				Name: "kn-event-darwin-arm64",
 				Size: 58_727_008,
-			}, {
-				Name:        "checksums.txt.pem",
-				Size:        1_348,
-				ContentType: "application/x-x509-ca-cert",
-			}, {
-				Name:        "checksums.txt.sig",
-				Size:        96,
-				ContentType: "application/pgp-signature",
 			}},
 		}},
 	}, {
@@ -59,14 +51,6 @@ func TestCreatePlan(t *testing.T) {
 			}, {
 				Name: "kn-event-darwin-arm64",
 				Size: 58_542_306,
-			}, {
-				Name:        "checksums.txt.pem",
-				Size:        1_348,
-				ContentType: "application/octet-stream",
-			}, {
-				Name:        "checksums.txt.sig",
-				Size:        96,
-				ContentType: "application/octet-stream",
 			}},
 		}},
 	}, {
@@ -240,9 +224,6 @@ func (tc resolvedCreatePlanTestCase) performTest(ctx context.Context, t testingT
 							Repo:  tc.args.repo,
 						},
 					},
-					Checksums: github.Checksums{
-						FileName: github.FileName{BaseName: "checksums", Extension: "txt"},
-					},
 				},
 				Site: config.Site{Type: config.TypeGitHub},
 			},

pkg/ghet/install/args.go

@@ -20,12 +20,6 @@ func (a Args) WithDefaults() Args {
 			Release: github.Release{
 				Tag: "latest",
 			},
-			Checksums: github.Checksums{
-				FileName: github.FileName{
-					BaseName:  "checksums",
-					Extension: "txt",
-				},
-			},
 		},
 		Site: config.Site{
 			Type:    config.TypeGitHub,

pkg/github/arch.go

@@ -17,6 +17,23 @@ const (
 	ArchS390X   Architecture = "s390x"
 )
 
+func noArchMatches(name string) bool {
+	archs := []Architecture{
+		ArchX86,
+		ArchAMD64,
+		ArchARM,
+		ArchARM64,
+		ArchPPC64LE,
+		ArchS390X,
+	}
+	for _, arch := range archs {
+		if arch.Matches(name) {
+			return false
+		}
+	}
+	return true
+}
+
 func (a Architecture) Matches(name string) bool {
 	return matchWith(name, archMatchers[a])
 }

pkg/github/assets.go

@@ -3,6 +3,8 @@ package github
 import (
 	"path"
 	"strings"
+
+	"github.com/cardil/ghet/pkg/match"
 )
 
 type FileName struct {
@@ -21,10 +23,47 @@ func (n FileName) ToString() string {
 	return n.BaseName + joiner + n.Extension
 }
 
+func (n FileName) isEmpty() bool {
+	return n.BaseName == "" && n.Extension == ""
+}
+
 type Checksums struct {
 	FileName
 }
 
+func emptyChecksums() []Checksums {
+	return []Checksums{
+		{NewFileName("checksums.txt")},
+		{NewFileName("checksums.out")},
+		{NewFileName("sha256sum.txt")},
+		{NewFileName("sha256sum.out")},
+		{NewFileName("sha512sum.txt")},
+		{NewFileName("sha512sum.out")},
+		{FileName{Extension: "sha256"}},
+		{FileName{Extension: "sha256sum"}},
+		{FileName{Extension: "sha512"}},
+		{FileName{Extension: "sha512sum"}},
+	}
+}
+
+func (c Checksums) matcher(basename string, arch Architecture, sys OperatingSystem) match.Matcher {
+	if c.isEmpty() {
+		cc := emptyChecksums()
+		mm := make([]match.Matcher, len(cc))
+		for i, ch := range cc {
+			mm[i] = ch.matcher(basename, arch, sys)
+		}
+		return match.Any(mm...)
+	}
+	return match.MatcherFn(func(name string) bool {
+		return c.ToString() == name ||
+			strings.HasPrefix(name, basename) &&
+				strings.HasSuffix(name, c.ToString()) &&
+				((arch.Matches(name) && sys.Matches(name)) ||
+					(noArchMatches(name) && noOsMatches(name)))
+	})
+}
+
 type Asset struct {
 	FileName
 	Architecture
@@ -44,3 +83,14 @@ func NewFileName(s string) FileName {
 		Extension: ext,
 	}
 }
+
+func (a Asset) Matches(filename string) bool {
+	name := strings.ToLower(filename)
+	basename := strings.ToLower(a.FileName.BaseName)
+	coords := strings.TrimPrefix(name, basename)
+	cm := a.Checksums.matcher(basename, a.Architecture, a.OperatingSystem)
+	return cm.Matches(name) ||
+		(strings.HasPrefix(name, basename) &&
+			a.Architecture.Matches(coords) &&
+			a.OperatingSystem.Matches(coords))
+}

pkg/github/os.go

@@ -29,6 +29,21 @@ func (os OperatingSystem) Matches(name string) bool {
 	return matchWith(name, osMatchers[os])
 }
 
+func noOsMatches(name string) bool {
+	oss := []OperatingSystem{
+		OSDarwin,
+		OSLinuxMusl,
+		OSLinuxGnu,
+		OSWindows,
+	}
+	for _, os := range oss {
+		if os.Matches(name) {
+			return false
+		}
+	}
+	return true
+}
+
 func CurrentOS() OperatingSystem {
 	family := OsFamily(runtime.GOOS)
 	//goland:noinspection GoBoolExpressions