Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Ember deprecations #16

Closed
habdelra opened this issue Jan 10, 2019 · 3 comments
Closed

Cleanup Ember deprecations #16

habdelra opened this issue Jan 10, 2019 · 3 comments
Assignees
@habdelra
Projects
Portfolio project

Comments

@habdelra
Copy link
Contributor

We've upgraded to Ember 3.7 in order to use the new events on the router service. As a result, I'm seeing these 2 deprecations a lot (I think they are framework deprecations):

DEPRECATION: You attempted to read "transition.queryParams" which is a private API. You should read the `RouteInfo` object on "transition.to" or "transition.from" which has the queryParams on it. [deprecation id: transition-state] See https://emberjs.com/deprecations/v3.x#toc_transition-state for more details.
        at logDeprecationStackTrace (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:86:1)
        at HANDLERS.(anonymous function) (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:11:1)
        at raiseOnDeprecation (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:110:1)
        at HANDLERS.(anonymous function) (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:11:1)
        at invoke (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:20:1)
        at deprecate (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:146:1)
        at Transition.get (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/-internals/routing/lib/system/router.js:46:1)
        at Class.model (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/@cardstack/routing/routes/cardstack.js:15:1)
        at Class.deserialize (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/-internals/routing/lib/system/route.js:933:1)
        at UnresolvedRouteInfoByParam.getModel (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/router_js.js:726:1)
        at _rsvp.Promise.resolve.then.then.then.then (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/router_js.js:565:1)
        at tryCatcher (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:313:1)
        at invokeCallback (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:483:1)
        at publish (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:469:1)
        at _runloop.backburner.schedule (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/ember-testing/lib/ext/rsvp.js:13:1)
        at invokeWithOnError (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:255:1)
        at Queue.flush (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:168:1)
        at DeferredActionQueues.flush (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:320:1)
        at Backburner._end (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:750:1)
        at Backburner._boundAutorunEnd (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:487:1)
        at process._tickCallback (internal/process/next_tick.js:68:7)

DEPRECATION: Use of `merge` has been deprecated. Please use `assign` instead. [deprecation id: ember-polyfills.deprecate-merge] See https://emberjs.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge for more details.
        at logDeprecationStackTrace (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:86:1)
        at HANDLERS.(anonymous function) (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:11:1)
        at raiseOnDeprecation (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:110:1)
        at HANDLERS.(anonymous function) (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:11:1)
        at invoke (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/handlers.js:20:1)
        at deprecate (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/debug/lib/deprecate.js:146:1)
        at Object.merge (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/@ember/polyfills/lib/merge.js:27:1)
        at Class._cacheFastBootCookie (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-cookies/services/cookies.js:133:1)
        at Class._writeFastBootCookie (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-cookies/services/cookies.js:126:1)
        at Class.write (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-cookies/services/cookies.js:87:1)
        at Class._write (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/session-stores/cookie.js:236:1)
        at Class.persist (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/session-stores/cookie.js:182:1)
        at Class.persist (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/session-stores/adaptive.js:156:1)
        at Proxy._callStoreAsync (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/internal-session.js:95:1)
        at Proxy._updateStore (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/internal-session.js:165:1)
        at Proxy._clear (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/internal-session.js:138:1)
        at Proxy._clearWithContent (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/internal-session.js:147:1)
        at _callStoreAsync.then.restoredContent (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/internal-session.js:86:1)
        at tryCatcher (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:313:1)
        at invokeCallback (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:483:1)
        at config.async (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/rsvp.js:546:1)
        at _runloop.backburner.schedule (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/ember-testing/lib/ext/rsvp.js:13:1)
        at invokeWithOnError (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:255:1)
        at Queue.flush (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:168:1)
        at DeferredActionQueues.flush (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:320:1)
        at Backburner._end (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:750:1)
        at Backburner._boundAutorunEnd (/var/folders/hz/y73qr9rn0jl_32glr10y0pkc0000gr/T/broccoli-330765t9FqUdhHz2L/out-842-broccoli_merge_trees/assets/backburner.js:487:1)
@habdelra
Copy link
Contributor Author

habdelra commented Feb 2, 2019

Looks like this was fixed upstream in the latest hub modules

@habdelra habdelra closed this as completed Feb 2, 2019
@habdelra
Copy link
Contributor Author

habdelra commented Feb 5, 2019 •
edited

i was mistaken--still there in fastboot.

@habdelra habdelra reopened this Feb 5, 2019
@habdelra habdelra added this to To do in Portfolio project Feb 5, 2019
@habdelra habdelra self-assigned this Mar 1, 2019
@habdelra habdelra mentioned this issue Mar 1, 2019
Closed
@habdelra
Copy link
Contributor Author

habdelra commented Mar 1, 2019

These deprecations are now fixed in @cardstack/cardstack 0.13.51

@habdelra habdelra moved this from To do to In progress in Portfolio project Mar 2, 2019
habdelra added a commit that referenced this issue Mar 2, 2019
@habdelra
Fixes #16 fix deprecations
cebd992
habdelra added a commit that referenced this issue Mar 2, 2019
@habdelra
Merge pull request #172 from cardstack/16-fix-deprecations
9848ce0 
Fixes #16 fix deprecations
Portfolio project automation moved this from In progress to Done Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@habdelra habdelra

Labels
None yet
Projects
Portfolio project
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@habdelra