Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portrait mode for dialog lines is not working #160

Closed
mapedorr opened this issue Feb 24, 2024 · 1 comment
Closed

Portrait mode for dialog lines is not working #160

mapedorr opened this issue Feb 24, 2024 · 1 comment
Assignees
@mapedorr
Labels
bug Something isn't working

Comments

@mapedorr
Copy link
Collaborator

mapedorr commented Feb 24, 2024 •
edited

Bug description

When Portrait is selected in PopochiuSettings, the game doesn't work.

Steps to reproduce

  1. Open Settings (in Popochiu dock).
  2. In Dialog Style select Portrait.
  3. Run the game.
  4. When a character says something, the game stops (crashes) without showing any error message in the Output.

Expected vs observed behavior

Texts should appear in Portrait mode as it was working in alpha 5.

Environment information (please complete):

  • OS type and version: Windows 11
  • Godot version: 4.2.1
  • Plugin version or branch: beta 1

Additional context

Nothing.
@mapedorr mapedorr added the bug Something isn't working label Feb 24, 2024
@mapedorr mapedorr self-assigned this Feb 24, 2024
mapedorr added a commit that referenced this issue Feb 24, 2024
@mapedorr
Fixes for #159 and #160
a8a4c82 
Improve behavior of all GUI templates for items use.
[upd] Use Mono font for Label in GUI copy progress popup.
[fix] Validate existance of avatars to fix Portrait component.
[fix] Now item use fallback is handled by the commands script of each
GUI template.
@mapedorr
Copy link
Collaborator Author

Fixed in #163

mapedorr added a commit that referenced this issue Feb 25, 2024
@mapedorr @stickgrinder
Fixes for #159 #160 #158 #162 (#163)
fc9a89e 
* Fixes for #159 and #160

Improve behavior of all GUI templates for items use.
[upd] Use Mono font for Label in GUI copy progress popup.
[fix] Validate existance of avatars to fix Portrait component.
[fix] Now item use fallback is handled by the commands script of each
GUI template.

* Fix #158

Ignore the polygon assignation process when editing a PopochiuClickable
from its .tscn file, or when it is a PopochiuCharacter.

* Fix #162

Now the copy process text is shown inside the Setup popup.

[fea] Also adds an Output message to inform the copy process is
completed.
[upd] Style of slots in 9 Verb GUI wasn't correct.
[fix] Update script templates so the method _on_item_used calls
E.command_fallback().

* Update message with potential misunderstanding

Cambridge dictionary says that: an assignation is a meeting that is secret or not allowed, especially one between two people having a romantic relationship.

Co-authored-by: Paolo Pustorino <stickgrinder@gmail.com>

* Use a progress bar to show GUI template process

Update code to follow suggestions made by @stickgrinder .

* Update style of copy progress panel to match the engine theme

---------

Co-authored-by: Paolo Pustorino <stickgrinder@gmail.com>
@mapedorr mapedorr mentioned this issue Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapedorr mapedorr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mapedorr