Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last whitespace character in a link displayed as %20 in preview when certain characters used in previous links #367

Closed
dealingwith opened this issue May 13, 2017 · 8 comments

Comments

@dealingwith
Copy link

I use Caret to edit Jekyll posts, which allow for {{site.baseurl}} variables, which I use inside internal links in case I ever move the blog:

screen shot 2017-05-13 at 9 52 55 am

Prior to the most recent update, these links did not preview correctly (they would not be formatted into links, I would see all the raw markdown). I just updated and now they display (they do not link anywhere, which is expected--Caret could have no idea how to handle that variable), which is great!

Now there is just one more odd bug...external links following the above nicely formatted link text end up with %20 for spaces in only the last contiguous whitespace character(s) of their text:

screen shot 2017-05-13 at 9 44 55 am

screen shot 2017-05-13 at 9 56 45 am

screen shot 2017-05-13 at 9 59 34 am

@dealingwith
Copy link
Author

Note that this only happens if there are links with the {{site.baseurl}} variable in the document. All links in documents without them are fine.

@dealingwith
Copy link
Author

Also note that is only links that occur after the variable that are affected.

screen shot 2017-05-13 at 10 04 50 am

@dealingwith
Copy link
Author

dealingwith commented May 13, 2017

Also note that other links with the variable are not affected! 😄

screen shot 2017-05-13 at 10 08 24 am

@dealingwith
Copy link
Author

These %20 whitespace characters also show up in the PDF export.

@astoilkov
Copy link
Contributor

This is now fixed in the latest Caret 2.1.3 release.

Closing this issue. Thank you for reporting.

@joshuaiz
Copy link

I'm using the 4.0.0beta9 and this issue is still there:

screen shot 2018-03-12 at 10 21 04 pm

@joshuaiz
Copy link

Just to follow up, deleting the links and then undoing all the deletions seems to fix this but then it brings up the 'Cannot find module 'emojis' - 4.0.0-beta9 #669' issue so I think these are related.

I'd be happy to have a setting to disable emojis entirely until these bugs are worked out.

@astoilkov
Copy link
Contributor

The emojis error will be fixed in the next release. We will also take a look at the link issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants