Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Dictionary doesn't seem to always work #437

Closed
dracan opened this issue Jul 12, 2017 · 13 comments
Closed

Add to Dictionary doesn't seem to always work #437

dracan opened this issue Jul 12, 2017 · 13 comments

Comments

@dracan
Copy link

dracan commented Jul 12, 2017

Some words I add still have the underline below the work and suggest spellings if I ctrl-space. Basically, as if the 'Add to Dictionary' didn't do anything.

This doesn't seem to always happen, and I can't see a pattern. A word I couldn't get it to add earlier, it's now just worked when I tried it again.

@astoilkov
Copy link
Contributor

Hi @dracan,

Thanks for reporting this problem. On what operating system are you running Caret?

@dracan
Copy link
Author

dracan commented Jul 12, 2017

It's Windows 10 (x64).

@astoilkov
Copy link
Contributor

@borekb - Have you experienced this problem?

@astoilkov astoilkov added the bug label Jul 12, 2017
@borekb
Copy link

borekb commented Jul 12, 2017

This happens for example if the word is before a comma or a dot, e.g., "this is an example asd." If I add "asd" to my custom dictionary, I think Caret actually adds "asd." and keeps underlining the text.

@dracan
Copy link
Author

dracan commented Jul 12, 2017

Where's the custom dictionary stored? I'll check mine.

@astoilkov
Copy link
Contributor

On Windows we use the native Spell Check API which automatically stores the custom words. We are actually not sure where exactly that data is stored.

@dracan
Copy link
Author

dracan commented Jul 12, 2017

Looks like it's here ...

C:\Users\Dan\AppData\Roaming\Microsoft\Spelling\en-GB\default.dic

And looking in that file, it's done as @borekb suggested, and included the punctuation.

LINQPad
Docker,
Kibana
Docker

@dracan
Copy link
Author

dracan commented Jul 12, 2017

That latter Docker would have been when it fixed itself in my earlier comment in this issue ...

A word I couldn't get it to add earlier, it's now just worked when I tried it again.

@dracan
Copy link
Author

dracan commented Jul 12, 2017

I think I did that later on in the document - so that perhaps didn't have a comma next to it.

@borekb
Copy link

borekb commented Jul 12, 2017

I usually just add a space before the comma or a dot before I add to my custom dictionary but this is definitely a Caret bug.

Also, sometimes, after deleting text, the spell checking spans a couple of lines and reports incorrect results. I think I've reported it somewhere but am too lazy to look it up :)

@astoilkov
Copy link
Contributor

astoilkov commented Jul 12, 2017

We have a bug then. Expect a fix soon. Thanks a lot for the investigation.

Also, sometimes, after deleting text, the spell checking spans a couple of lines and reports incorrect results. I think I've reported it somewhere but am too lazy to look it up :)

Yes. You have. We will fix this too.

@astoilkov
Copy link
Contributor

This issue is now fixed internally. The fix will land in the next Caret release. I will close this issue when that happens.

@astoilkov
Copy link
Contributor

This is now fixed in the latest 3.2.2 Caret release.

Closing this issue. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants