-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very slow checking of installed crate versions on cargo binstall
#1295
Comments
cargo binstall
Actually yes, you found out the cause faster than I do. Our crates.io client has a one request per each second rate limit, I think it was copied from crates_io_api. |
We could remove that and just the global rate limit policy. |
Fixed #1295 The 1 request per second rate-limit is too strict and it makes `cargo-binstall` very slow when resolving many crates in parallel. Relying on the rate-limit in `binstalk_downloader::remote::Client` should be good enough. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Fixed #1295 The 1 request per second rate-limit is too strict and it makes `cargo-binstall` very slow when resolving many crates in parallel. Relying on the rate-limit in `binstalk_downloader::remote::Client` should be good enough. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@0atman We have released cargo-binstall v1.3.0 which should fixed this by switching to sparse index and use the global rate-limit instead. |
If you, like me, maintain a large list of system tools in Rust and re-run the install line now and then to keep up to date, you'll notice a very long delay checking each crate for being up to date, even if no version bump has happened.
After package indexing, which is very fast, this process is entirely local and so shouldn't be slow. Yet it is, about 1s delayed per item.
Here's my preposterous install line that I will take no notes on:
Output immediately jumps to here, then spins 1s for each of the following lines:
Is there a
sleep(1)
in there somewhere? 😅The text was updated successfully, but these errors were encountered: