Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching in release-dry-run #1419

Closed
NobodyXu opened this issue Sep 28, 2023 · 2 comments · Fixed by #1422
Closed

Fix caching in release-dry-run #1419

NobodyXu opened this issue Sep 28, 2023 · 2 comments · Fixed by #1422
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Sep 28, 2023 •
edited
Loading

It seems that somehow it caches the installed crates manifest but does not cache rsign2, causing our CI to fail.
@NobodyXu NobodyXu added the github_actions Pull requests that update GitHub Actions code label Sep 28, 2023
@NobodyXu
Copy link
Member Author

Just moving the cargo-binstall and the minisign, rage installation before the caching would fix it.

@NobodyXu
Copy link
Member Author

It also happened in release-dry-run for other targets.

I think the problem is that it's picking up old cache which doesn't habe rage and minisign installed in release-build

@NobodyXu NobodyXu changed the title Fix caching in x86_64h-apple-darwin Fix caching in release-dry-run Sep 28, 2023
NobodyXu added a commit that referenced this issue Sep 28, 2023
@NobodyXu
Fix release-packages and release-cli workflow
5ccadf4 
Fixed #1419

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this issue Sep 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 29, 2023
@NobodyXu
Fix release-packages and release-cli workflow (#1422)
3d68641 
* Fix `release-packages` and `release-cli` workflow

Fixed #1419

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Use `taiki-e/install-action` for `rsign2` & `rage` in `release-packages.yml`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix release-packages and release-cli workflow cargo-bins/cargo-binstall
1 participant
@NobodyXu