Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to skip fatal error #1548

Closed
owenstake opened this issue Dec 27, 2023 · 4 comments · Fixed by #1559
Closed

How to skip fatal error #1548

owenstake opened this issue Dec 27, 2023 · 4 comments · Fixed by #1559
Assignees

Comments

@owenstake
Copy link

I try to install multi bin with one-line command cargo-binstall jless ripgrep . Although jless is fail to install, but I still want to install ripgrep in this one-line command. How can I achieve this?
image

@NobodyXu
Copy link
Member

We can add a new option --continue-on-failure for your use case.

@passcod What do you think?

@passcod
Copy link
Member

passcod commented Dec 27, 2023

Sounds good

@NobodyXu NobodyXu self-assigned this Dec 30, 2023
@NobodyXu
Copy link
Member

Just to let you know I'm working on this and will cut a new release once this feature is done.

NobodyXu added a commit that referenced this issue Jan 6, 2024
Resolve #1548

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
* feat: Impl new option `--continue-on-failure`

Resolve #1548

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Add new e2e-tests continue-on-failure

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Rm dup line ion `e2e-tests/live.sh`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Fix shellcheck

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Fix `BinstallError::crate_errors` if `errors.len()` is 1

In that case, it should return `Some(Self::CrateContext(_))` instead of
`Some(Self::Errors(_))`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Add more tests to `e2e-tests/continue-on-failure.sh`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Propagate crate errors on `confirm()` err

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

* Test having two errors in `e2e-tests/continue-on-failure.sh`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

---------

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Member

NobodyXu commented Jan 8, 2024

I will cut a new release this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants