Optimize fetch_crate_cratesio for exact version
#1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one issue with the optimisation: If the version requested by user is yanked, it would continue to fetch it instead of rejecting it. This is inconsistent with the existing general implementation, but given that users specifically requested that version, maybe it's ok for our algorithm to fetch and try installing it, even if it is yanked? Though in that case maybe a warning is needed or rejected, which means we would still need a http request into https://crates.io/api/v1/crates/$crate/$version , but it does not have to fetch information for all versions. |
8 tasks
If `version_req` requests a specific version instead of a range, then there is no need to pull all versions available from https://crates.io/api/v1/crates Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
force-pushed
the
optimize/fetch_crate_cratesio
branch
from
15a13df
to
6fb8919
Compare
|
I've fixed the issue by querying https://crates.io/api/v1/crates/$crate/$version |
passcod
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
version_reqrequests a specific version instead of a range, then there is no need to pull all versions available from https://crates.io/api/v1/cratesSigned-off-by: Jiahao XU Jiahao_XU@outlook.com