Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify --version usage and add a warning at runtime #116

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Clarify --version usage and add a warning at runtime #116

merged 3 commits into from
Apr 28, 2022

Conversation

passcod
Copy link
Member

@passcod passcod commented Apr 27, 2022

Fixes #113

Did both:

  • Help message is fixed up to mention that it's the same syntax/semantics as a Cargo.toml version field
  • When using --version 1.2.3 and the version resolves to something different, warn and reconfirm.

@passcod passcod requested a review from ryankurte April 27, 2022 10:44
ryankurte
ryankurte approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

somehowchris
somehowchris reviewed Apr 28, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@passcod passcod merged commit d68b0a2 into cargo-bins:main Apr 28, 2022
@passcod passcod deleted the clarify-version-help branch April 28, 2022 21:33
This was referenced Apr 30, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somehowchris somehowchris somehowchris left review comments

@ryankurte ryankurte ryankurte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warning/error/abort if version does not exist/is yanked
3 participants
@passcod @ryankurte @somehowchris