Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation script on MacOS #1263

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix installation script on MacOS #1263

merged 1 commit into from
Aug 9, 2023

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Aug 9, 2023

Fixed #1254

and also add CI for installation script.

Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu added this pull request to the merge queue Aug 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 9, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 1c886d8 Aug 9, 2023
33 checks passed
@NobodyXu NobodyXu deleted the ci branch August 9, 2023 09:56
@smallstepman
Copy link
Contributor

You might want to consider adding https://github.com/super-linter/super-linter GHA to your repository instead of manually adding linters (like shellcheck.yml here).

super-linter will run a plethora of linters on your repo, including clippy, shellcheck, actionlint, it will also lint your markdown files, check for duplicates in code, lint dockerfiles... Setting it up is easy, but be aware fixing initial lint errors will take a good chunk of your day

@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 9, 2023

You might want to consider adding https://github.com/super-linter/super-linter GHA to your repository instead of manually adding linters (like shellcheck.yml here).

Thanks!

including clippy

We already have clippy so we don't want it to be checked again.
Everything other than Rust linters is good and I'd like to add them.

I would also accept PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New install script compatibility with MacOS GHA runners
3 participants