Fix aarch64-apple-darwin fallback to x86_64h
#1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `arch -arch x86_64h /usr/bin/true` to decides whether fallback is feasible. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
passcod
reviewed
Aug 11, 2023
| // These two tasks are never cancelled, so it can only fail due to | ||
| // panic, in which cause we would propagate by also panic here. | ||
| let x86_64h_task = tokio::spawn(is_arch_supported("x86_64h")); | ||
| let x86_64_task = tokio::spawn(is_arch_supported("x86_64")); | ||
| [ | ||
| // Prefer universal as it provides native arm executable |
There was a problem hiding this comment.
Hmm unrelated to this PR but I wonder about that, given that universal can contain anything really. Like you could have a x64 and x64h universal with no arm
There was a problem hiding this comment.
Yeah, according to bjorn3 on zulip it could even have a PowerPC and m68k binary inside.
passcod
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolve #1277
Run
arch -arch x86_64h /usr/bin/trueto decides whether fallback is feasible.