Fix GitHub token auto discovery

[NobodyXu]

Fixed #1333

• Rm dep gh-token since it is broken and we can simply run gh auth token in cargo-binstall instead.
• binstalk-downloader: Make sure GitHub token is at least 40B long and other than the _, composes of only alphanumeric characters.
• Warn on failure to read git/credential files
• Optimize try_from_home to avoid heap allocation of PathBuf

[simonsan]

• Rm dep gh-token since it is broken and we can simply run gh auth token in cargo-binstall instead.

That assumes someone has installed the gh cli tool locally, right?

Maybe it would be good to keep that logic, in case someone hasn't installed it and test for the presence of gh cli and if present, use it?

[NobodyXu]

@simonsan If gh isn't available, this PR would simply log a warning message and continue.

I don't see why gh-token should be kept, if gh is not installed then there's likely no gh token (unless it's a leftover from uninstalled gh), so gh-token would also return an Err.

[NobodyXu]

@simonsan Can you try this PR and see if it fixed the bug for you please?
You can download the pre-built artifacts here

[simonsan]

@simonsan Can you try this PR and see if it fixed the bug for you please? You can download the pre-built artifacts here

PS C:\Users\dailyuse> cargo binstall cargo-audit --force -y
 WARN Failed to read git credential file C:\Users\dailyuse\.git-credentials err=Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }
 INFO resolve: Resolving package: 'cargo-audit'
 WARN Failed to send quickinstall report for package cargo-audit-0.18.1-x86_64-pc-windows-msvc: Failed to download from remote: could not HEAD https://warehouse-clerk-tmp.vercel.app/api/crate/cargo-audit-0.18.1-x86_64-pc-windows-msvc.tar.gz: HTTP status server error (500 Internal Server Error) for url (https://warehouse-clerk-tmp.vercel.app/api/crate/cargo-audit-0.18.1-x86_64-pc-windows-msvc.tar.gz)
 WARN The package cargo-audit v0.18.1 will be downloaded from third-party source QuickInstall
 INFO This will install the following binaries:
 INFO   - cargo-audit.exe (cargo-audit.exe -> C:\Users\dailyuse\.cargo\bin\cargo-audit.exe)
 INFO Installing binaries...
 INFO Done in 191.8086427s

It throws a few warnings, but it works now. Still takes 3 Minutes though.

[NobodyXu]

It throws a few warnings, but it works now. Still takes 3 Minutes though.

Given that Github token is provided, I suspect this might be a network issue, or maybe related to use of http3.

Can u try building this branch locally without http3 please?

[simonsan]

It throws a few warnings, but it works now. Still takes 3 Minutes though.

Given that Github token is provided, I suspect this might be a network issue, or maybe related to use of http3.

Can u try building this branch locally without http3 please?

PS C:\Users\dailyuse> cargo binstall cargo-audit --force -y
 INFO resolve: Resolving package: 'cargo-audit'
 WARN The package cargo-audit v0.18.1 will be downloaded from third-party source QuickInstall
 INFO This will install the following binaries:
 INFO   - cargo-audit.exe (cargo-audit.exe -> C:\Users\dailyuse\.cargo\bin\cargo-audit.exe)
 INFO Installing binaries...
 INFO Done in 158.4539701s

With GITHUB_TOKEN env var, still want me to build without HTTP/3?

[simonsan]

PS C:\Users\dailyuse\dev-src\cargo-binstall> cargo run -p cargo-binstall -- cargo-audit --force -y
    Finished dev [unoptimized + debuginfo] target(s) in 0.39s
     Running `C:\.cargo-target\debug\cargo-binstall.exe cargo-audit --force -y`
 INFO resolve: Resolving package: 'cargo-audit'
 WARN The package cargo-audit v0.18.1 will be downloaded from third-party source QuickInstall
 INFO This will install the following binaries:
 INFO   - cargo-audit.exe (cargo-audit.exe -> C:\Users\dailyuse\.cargo\bin\cargo-audit.exe)
 INFO Installing binaries...
 INFO Done in 182.9846414s

This PR with GITHUB_TOKEN set.

[NobodyXu]

With GITHUB_TOKEN env var, still want me to build without HTTP/3?

Just want to check if it's HTTP/3 causing slowdown

[simonsan]

With GITHUB_TOKEN env var, still want me to build without HTTP/3?

Just want to check if it's HTTP/3 causing slowdown

The one after that comment built with default features, so no HTTP/3 and has still taken 3 minutes.

[NobodyXu]

The one after that comment built with default features, so no HTTP/3 and has still taken 3 minutes.

Not sure what is wrong then.

Can it be that GitHub rate limits your IP or Github token?