Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip if already installed and add new cmdline option --force #282

Merged
merged 23 commits into from
Aug 8, 2022
Merged

Skip if already installed and add new cmdline option --force #282

merged 23 commits into from
Aug 8, 2022

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Aug 4, 2022 •
edited
Loading

Resolve #270

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu NobodyXu added the PR: improvement PR that improves existing features or code label Aug 4, 2022
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 4, 2022

This PR is waiting for #281 to be merged to avoid merge conflicts.

@NobodyXu NobodyXu marked this pull request as ready for review August 5, 2022 05:43
@NobodyXu NobodyXu requested a review from passcod August 5, 2022 05:43
@NobodyXu NobodyXu added the PR: bugfix PR that fixes a bug label Aug 5, 2022
@NobodyXu NobodyXu removed the PR: bugfix PR that fixes a bug label Aug 5, 2022
@NobodyXu NobodyXu changed the title Skip if already installed Skip if already installed and add new cmdline option --force Aug 5, 2022
passcod
passcod requested changes Aug 6, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@passcod
Copy link
Member

passcod commented Aug 6, 2022 •
edited
Loading

Also we should log::info!("package {name} v{version} is already installed, use --force to override")

@passcod passcod mentioned this pull request Aug 6, 2022
Merged
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 7, 2022

Also we should log::info!("package {name} v{version} is already installed, use --force to override")

I added the logging, though the format is a little bit different.

@NobodyXu NobodyXu requested a review from passcod August 7, 2022 09:55
passcod
passcod reviewed Aug 7, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@NobodyXu
Add new option Options::force
04fee49 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Skip crates that are already installed.
ac08553 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Minor Refactor: Gather code related to crate_names
6716d75 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Use block_in_place for loading metadata
4dae214 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Refactor & Optimize: Launch target detection as soon as possible
b4c6db7 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Detect install_path & load metadata in block_in_place
b8c4483 
since they involves blocking fs io.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Refactor: Run TempDir creation in block_in_place
4b79abe 
Since it could also issues blocking operations.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Pass --force to cargo-install
34f714c 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
FIx ci-scripts/tests.sh: Use --force to force installation.
20c7b61 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Impl new fn helpers::parse_version
51d6b30 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rename CrateName::version to version_req and change its type to
dd8e6a4 
`Option<VersionReq>`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Take &VersionReq for 1st param of find_version
497ef80 
instead of `&str`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Use &VersionReq for param version_req of fetch_crate_cratesio
686cae6 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Use VersionReq for Options::version_req and update usage of
065f62a 
`CrateName` in `binstall::install`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Test --version and $crate_name@$version in tests.sh
431992d 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Skip only if version_req is satisfied
2c2b3c0 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
log::info! if a crate is skipped due to already installed
7f4edfd 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Test skip when installed in ci-scripts/tests.sh
4a17460 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix testing skip if installed in ci-scripts/tests.sh
d932f1c 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add new trait VersionReqExt and impl it for VersionReq
b94dc97 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Use VersionReqExt::is_latest_compatible in entry:367
3692651 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Test When 0.11.0 is installed but can be upgraded in tests.sh
b69d7e7 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod August 8, 2022 08:25
passcod
passcod reviewed Aug 8, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@NobodyXu
Ignore if package already up-to-date
a271e69 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod August 8, 2022 09:21
@NobodyXu NobodyXu mentioned this pull request Aug 8, 2022
Closed
@NobodyXu NobodyXu merged commit 9034f78 into main Aug 8, 2022
@NobodyXu NobodyXu deleted the skip-if-already-installed branch August 8, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
PR: improvement PR that improves existing features or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour when crate already installed: overriden if downloading and ignored if already installed
2 participants
@NobodyXu @passcod