Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add unsupported crate example #385

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Sep 15, 2022

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@azzamsa
Copy link
Contributor Author

azzamsa commented Sep 15, 2022

I have other examples, but they are simmilar. So I just exclude them. Two of them doesn't work.

  1. rust-analyzer: maybe because it doesn't exists on crates.io, so binstall ask to install from source
cargo binstall rust-analyzer --no-symlinks \
  --pkg-url="https://github.com/rust-lang/rust-analyzer/releases/download/{ version }/{ name }-{ target }.gz" \
  --pkg-fmt tar --bin-dir "{ bin }" --install-path /opt
❯ cargo binstall rust-analyzer --no-symlinks --pkg-url="https://github.com/rust-lang/rust-analyzer/releases/download/{ version }/{ name }-{ target }.gz" --pkg-fmt tar --bin-dir "{ bin }" --install-path /tmp/foo
11:13:37 [INFO] Resolving package: 'rust-analyzer'
11:13:40 [WARN] The package will be installed from source (with cargo)
Do you wish to continue? yes/[no]
?^
  1. git-cliff: instead of finding git-cliff. It tries to install git-cliff-completions and git-cliff-mangen
❯ cargo binstall git-cliff --no-symlinks --pkg-url="https://github.com/orhun/git-cliff/releases/download/v{ version }/{ name }-{ version }-{ target }.tar.gz" --pkg-fmt tgz --bin-dir "{ name }-{ version }/{ bin }" --install-path /tmp/foo
11:14:27 [INFO] Resolving package: 'git-cliff'
11:14:31 [INFO] The package will be downloaded from github.com
11:14:31 [INFO] This will install the following binaries:
11:14:31 [INFO]   - git-cliff-completions (git-cliff-completions -> /tmp/foo/git-cliff-completions-v0.9.0)
11:14:31 [INFO]   - git-cliff-mangen (git-cliff-mangen -> /tmp/foo/git-cliff-mangen-v0.9.0)
Do you wish to continue? yes/[no]
? ^C11:14:33 [WARN] Installation cancelled

@NobodyXu
Copy link
Member

@azzamsa rust-analyzer should be installed using rustup, as it is now a rust-lang project.

@azzamsa
Copy link
Contributor Author

azzamsa commented Sep 15, 2022

@azzamsa rust-analyzer should be installed using rustup, as it is now a rust-lang project.

This news to me https://rust-analyzer.github.io/manual.html#rustup.
I always use curl to update my rust-analyzer. Last time I check the installation page, there is no mention of rustup.

Btw, do you have any clue about the error occurred in the git-cliff?

@NobodyXu
Copy link
Member

git-cliff: instead of finding git-cliff. It tries to install git-cliff-completions and git-cliff-mangen

This should be a bug of cargo-binstall, I would investigate on that.
P.S. cargo-binstall v0.13.1 should support installing git-cliff out-of-the-box.

@NobodyXu NobodyXu merged commit a5ffba1 into cargo-bins:main Sep 15, 2022
@azzamsa
Copy link
Contributor Author

azzamsa commented Sep 15, 2022

P.S. cargo-binstall v0.13.1 should support installing git-cliff out-of-the-box.

Why this the case? I don't get any clue from the pre-release page.

@azzamsa azzamsa deleted the examples branch September 15, 2022 11:39
@NobodyXu
Copy link
Member

Why this the case? I don't get any clue from the pre-release page.

Please checkout #310 , #312 , #329 and the ongoing #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants