Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl try multiple default bin dirs #417

Merged
merged 16 commits into from Sep 25, 2022
Merged

Impl try multiple default bin dirs #417

merged 16 commits into from Sep 25, 2022

Conversation

NobodyXu
Copy link
Member

Replace #373

passcod and others added 11 commits September 24, 2022 14:10
@passcod @NobodyXu
Make bin-dir an Option
4c6aa6c
@passcod @NobodyXu
Use cargo-release as a test case
199fec7
@passcod @NobodyXu
WIP: Try multiple default bin dirs
fb2b0ee
@passcod @NobodyXu
Update bins.rs
d93b369
@passcod @NobodyXu
Update cargo_toml_binstall.rs
cb4f727
@NobodyXu
Optimize & Prepare for support multi bin-paths
b6c9c26 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Ensure quickinstall bin_dir work as usual.
60c5417 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Rm dup entries in FULL_FILENAMES
26dee3a 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add second version of NOVERSION_FILENAMES
e65e021 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Impl multiple default bin-dirs
68ccc6b 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Improve doc for BinFile::from_product
fe6cb17 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu marked this pull request as ready for review September 24, 2022 07:29
@NobodyXu NobodyXu added PR: feature work PR that provides or works on a new feature PR: improvement PR that improves existing features or code labels Sep 24, 2022
@NobodyXu
Copy link
Member Author

I would like to wait for #416 so that we can make a minor release.
Also, we cannot properly evaluate this PR until #416 is fixed.

@NobodyXu
Copy link
Member Author

Regression: Installing sccache now fails due to BinFile error.

@NobodyXu
Fix QuickInstall::target_meta
d638961 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Member Author

Regression: Installing sccache now fails due to BinFile error.

Fixed.

@NobodyXu NobodyXu enabled auto-merge (squash) September 25, 2022 07:22
@NobodyXu NobodyXu enabled auto-merge (squash) September 25, 2022 08:30
@NobodyXu
Add comment to FULL_FILENAMES & NOVERSION_FILENAMES
8dfe7a2 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Update comment
77e3e2b 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu merged commit e034d69 into main Sep 25, 2022
@NobodyXu NobodyXu deleted the impl-try-multiple-default-bin-dirs branch September 25, 2022 12:15
This was referenced Sep 25, 2022
Closed
Merged
Merged
NobodyXu added a commit that referenced this pull request Sep 28, 2022
@NobodyXu
Make binaries with required-features optional (#438)
f482e36 
* Make binaries with `required-features` optional so that crates like `sccache` would work as expected.
* Fix `infer_bin_dir_template`: concat with `data.bin_path` introduced in #417 
* Always `chmod +x $bin` on unix in case the archive (e.g. `sccache`) did not set the executable bit of fmt == Bin.
* CI: Install `sccache` but do not run it since it requires cargo env to be ready

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
PR: feature work PR that provides or works on a new feature PR: improvement PR that improves existing features or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @passcod