Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revoke permissions for builder #86

Merged
merged 1 commit into from Jul 24, 2022
Merged

revoke permissions for builder #86

merged 1 commit into from Jul 24, 2022

Conversation

alsuren
Copy link
Collaborator

@alsuren alsuren commented Jul 24, 2022

I think that this solves #49 without any added complexity.

I stumbled across this setting when trying to set up the webhook based scheme described in #49.
The paper trail went something like: https://github.com/organizations/cargo-quick/settings/actions
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token

This allowed me to know that it was possible at the top level, and then I jumped into vscode to see whether it was possible to use it at the job level (using the red hat yaml plugin, which pointed me at https://json.schemastore.org/github-workflow.json)

Turns out it is: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions

@alsuren
Copy link
Collaborator Author

alsuren commented Jul 24, 2022

Don't worry about the failing test. This only exists because I have a special case for the actions branch, which happens to have a race in it.

@alsuren alsuren merged commit 0bcffc0 into main Jul 24, 2022
@alsuren alsuren mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant