Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the project to the latest world version #237

Merged
merged 5 commits into from Sep 13, 2020
Merged

Update the project to the latest world version #237

merged 5 commits into from Sep 13, 2020

Conversation

Veetaha
Copy link
Contributor

@Veetaha Veetaha commented Aug 1, 2020 •
edited

Closes #238

  • Update all dependencies versions to latest ones
  • Replace rustfmt-preview with rustfmt
  • Replace failure with anyhow
  • Remove quicli completely
  • Update cargo authors copied code to latest cargo master
  • Fix clippy lints:
    • Replace &PathBuf to &Path in code
    • Remove bare use crate_name entires
    • Replace unexported pub with pub(crate)
  • Apply some cosmetic impl refactorings

@Veetaha Veetaha changed the title Update the project to the latest word version Update the project to the latest world version Aug 1, 2020
@Veetaha Veetaha force-pushed the master branch 5 times, most recently from 0a0c4d6 to d215b0a Compare August 1, 2020 19:08
@Veetaha Veetaha mentioned this pull request Aug 1, 2020
Merged
@Veetaha
Copy link
Contributor Author

Veetaha commented Aug 1, 2020

I have replaced file:// with file:/// in a test for git submodules because cargo no longer tolerates this syntax, see my comment here: rust-lang/cargo#7238 (comment)

@k0pernicus
Copy link
Collaborator

k0pernicus commented Aug 29, 2020 •
edited

Awesome @Veetaha, thanks a lot for your big update 🎉

Sounds good to me :)

@EverlastingBugstopper I think this should be the start of a new git tag, what do you think about this idea?

@k0pernicus
Copy link
Collaborator

k0pernicus commented Sep 12, 2020 •
edited

In my opinion, this should be the last changes before the next version release...

@sassman What do you think about that?
Do we attempt to work on #205 before merging those big changes?

@sassman
Copy link
Member

sassman commented Sep 12, 2020

@k0pernicus as it seems there is more cleanup work to do in #205
So I'd suggest getting this bigger one upstreamed, then I would rebase and work thru the changes needed to get #205 on the street. But release related, I would opt for releasing without #205 to not delay a release further. IMO there are good helpful features / fixes already there that justify a new release, #205 can be a followup release.

@Veetaha
Copy link
Contributor Author

Veetaha commented Sep 12, 2020

Rebased

@k0pernicus
Copy link
Collaborator

Great, thanks!

I will check this as soon as #242 is fine.

@k0pernicus
Copy link
Collaborator

@Veetaha Is it possible to rebase with the latest master changes please?
Thanks in advance :)

@Veetaha
Update the project to the latest word version
da6c788 
* Update all dependencies version to latest ones
* Remove `quicli` completely
* Replace failure with anyhow
* Update cargo authors copied code to latest cargo master
* Fix clippy lints:
  * Replace &PathBuf to &Path in code
  * Remove `use crate_name` entires
  * Replace unexported `pub` with `pub(crate)`
* Apply some cosmetic impl refactorings
@Veetaha
Replace rustfmt-preview with stable rustfmt
d837ed1
@Veetaha
Use three slashes after the file: scheme,
a60c6b9 
This is a small breaking change in cargo, because they no longer try to
normalize urls: rust-lang/cargo#7238
@Veetaha
Git commit fix file:// scheme for unix now ;d
9c4f919
@Veetaha Veetaha force-pushed the master branch 2 times, most recently from 66ea0ed to fdbfcb2 Compare September 12, 2020 13:10
@Veetaha
Copy link
Contributor Author

Veetaha commented Sep 12, 2020

Done

sassman
sassman approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@sassman sassman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k0pernicus
Copy link
Collaborator

Thanks again for your (big) contribution @Veetaha :)

@k0pernicus k0pernicus merged commit f864e04 into cargo-generate:master Sep 13, 2020
@k0pernicus k0pernicus mentioned this pull request Sep 13, 2020
Closed
@k0pernicus k0pernicus added this to the 0.5.1 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sassman sassman sassman approved these changes

@k0pernicus k0pernicus k0pernicus approved these changes

@ashleygwilliams ashleygwilliams Awaiting requested review from ashleygwilliams

@EverlastingBugstopper EverlastingBugstopper Awaiting requested review from EverlastingBugstopper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

Update to the latest world version
3 participants
@Veetaha @k0pernicus @sassman