Compile with target-cpu for more optimizations #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/foundation-arch.md and https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/runtimes-avx2.md we can set these target-cpu settings. I introduced a small refactoring so it's easier to encapsulate the architecture parsing. Is cargo-lambda meant to work with both `provided.al2` AND `provided`? I'm not sure what assumptions can be made about `provided`
|
I'm not particularly interested in making it work for |
|
Thanks a lot for making this changes! @simonvandel do you mind running |
|
I just double-checked cargo fmt and clippy; No changes. So should be ready for CI. |
|
Thanks again for your contribution! I'll probably release a new version with this change this weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/foundation-arch.md and https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/runtimes-avx2.md we can set these target-cpu settings.
I introduced a small refactoring so it's easier to encapsulate the architecture parsing.
Is cargo-lambda meant to work with both
provided.al2ANDprovided? I'm not sure what assumptions can be made aboutprovided