Ported old fix to avoid saving cookie if nothing changed

cargo-one · Mar 15, 2024 · 4d2a627 · 4d2a627
1 parent 7a4a7e1
commit 4d2a627
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/src/flask_session/sessions.py b/src/flask_session/sessions.py
@@ -205,7 +205,9 @@ def save_session(self, app, session, response):
                 response.delete_cookie(
                     app.config["SESSION_COOKIE_NAME"], domain=domain, path=path
                 )
-            return
+            return None
+        elif not session.modified:
+            return None
 
         # Get the new expiration time for the session
         expiration_datetime = self.get_expiration_time(app, session)
@@ -315,7 +317,9 @@ def save_session(self, app, session, response):
                 response.delete_cookie(
                     app.config["SESSION_COOKIE_NAME"], domain=domain, path=path
                 )
-            return
+            return None
+        elif not session.modified:
+            return None
 
         # Get the new expiration time for the session
         expiration_datetime = self.get_expiration_time(app, session)
@@ -404,7 +408,9 @@ def save_session(self, app, session, response):
                 response.delete_cookie(
                     app.config["SESSION_COOKIE_NAME"], domain=domain, path=path
                 )
-            return
+            return None
+        elif not session.modified:
+            return None
 
         # Get the new expiration time for the session
         expiration_datetime = self.get_expiration_time(app, session)
@@ -522,7 +528,9 @@ def save_session(self, app, session, response):
                 response.delete_cookie(
                     app.config["SESSION_COOKIE_NAME"], domain=domain, path=path
                 )
-            return
+            return None
+        elif not session.modified:
+            return None
 
         # Get the new expiration time for the session
         expiration_datetime = self.get_expiration_time(app, session)
@@ -690,7 +698,9 @@ def save_session(self, app, session, response):
                 response.delete_cookie(
                     app.config["SESSION_COOKIE_NAME"], domain=domain, path=path
                 )
-            return
+            return None
+        elif not session.modified:
+            return None
 
         # Serialize session data
         serialized_session_data = self.serializer.dumps(dict(session))