-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Static Resources in Example Project #105
Include Static Resources in Example Project #105
Conversation
Thanks for opening this PR, @vbrandl! While I do appreciate the addition, and the changes themselves do look correct to me, I don't think we should add this to either of the existing example projects. I think it's out of scope given both of their defined purposes and perhaps would be better suited to a later example with more practical use, e.g. an example use of What do all you think, @trha @eupn @antigravityla @snawaz? |
I could also create a third example repo and use https://github.com/vbrandl/cargo2nix-ructe-testcase as a base. Also is there a better way to extend |
That could work, sure! We'd need to write up a suitable tutorial for it, of course, but the Rust and Nix code for it is simple enough that I could see it being a good example project. 👍 Sadly, there isn't a way to duplicate the values for |
I reverted the changes in the existing example project and added a third example. I don't know enough about nix expressions yet to implement the change you proposed for |
I think it should be on a separate branch, since it's conceptually a different change that will need to be discussed and evaluated separately. I'll review it as soon as I can, but I'm currently away from a computer at the moment. Please bear with me for a little bit! If someone else wants to swoop in and take this on, that'd be cool too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @vbrandl. Looks good to me! 👍
Would you mind rebasing against the latest master
and dropping the first few commits, including the reverts, from the PR?
f8f4a47
to
05a5819
Compare
I rebased against upstream master and removed the old commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work, @vbrandl! Looks good to me.
I'll open an issue for writing up a proper tutorial for it.
This shows an example usage of
localPatterns
to include static resources in the build sandbox