Remove unused sha256 argument for Git dependencies #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument has been rendered unused since the transition to `builtins.fetchGit` for all Git dependencies. Since a minor release is coming soon, this breaking change should now be safe to roll out.
trha
suggested changes
Jul 13, 2020
|
@trha Sure! I'll do that next. I also noticed that I can turn |
added 2 commits
July 13, 2020 17:16
Since the `Owned` case has been eliminated in the previous commit, there is no need to use `std::borrow::Cow` for this field anymore.
This is no longer necessary, now that we use `builtins.fetchGit` everywhere.
|
Done! Would you mind re-reviewing, please, @trha? |
|
Okay, merging this in. I imagine this should be okay, since we've been awaiting this transition for a long time now. |
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
checksumfield ofResolvedPackagefromOption<Cow<'a, str>toOption<&'a str>.Removed
sha256argument for Git dependencies.serde_jsondependency.prefetch_gitfunction.nix-prefetch-gitwrapper fromdefault.nix.This argument has been rendered unused since the transition to
builtins.fetchGitfor all Git dependencies was made (#113). Since a minor release is coming soon, due to #119, this breaking change should now be safe to roll out.Closes #102.