This repository has been archived by the owner on Mar 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Add functionality #27
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b872b02
Ignore .bundle directory from bundler
shortdudey123 d6916db
Add pry for dev debugging
shortdudey123 4a96967
Fix items per page limit
shortdudey123 941f5d2
Add rubocop linting
shortdudey123 239b7a4
Ruby 1.9.3 was already EOL'd
shortdudey123 143de23
Fix yard warnings
shortdudey123 4d3423c
Add delete and patch http methods to client
shortdudey123 bb19d76
Add create, update, delete for hosts
shortdudey123 6c3c3cb
Add TravisCI testing back in for Ruby1.9.3
shortdudey123 046b371
Move TravisCI testing to their new infra
shortdudey123 bcda953
Add spec for MMS::Resource::Host
shortdudey123 ada4b1b
Bump gem version from 0.1.5 to 0.2.0
shortdudey123 0cb1ece
Correctly fix an assignemnt syntax issue
shortdudey123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ Gemfile.lock | |
.buildpath | ||
.project | ||
.ruby-version | ||
.bundle/ | ||
.yardoc/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
# Offense count: 2 | ||
Lint/HandleExceptions: | ||
Exclude: | ||
- 'lib/mms/resource/group.rb' | ||
|
||
# Offense count: 2 | ||
Lint/RescueException: | ||
Exclude: | ||
- 'lib/mms/cli.rb' | ||
|
||
# Offense count: 84 | ||
# Configuration parameters: AllowURI, URISchemes. | ||
Metrics/LineLength: | ||
Max: 159 | ||
|
||
# Offense count: 11 | ||
# Configuration parameters: CountComments. | ||
Metrics/MethodLength: | ||
Max: 24 | ||
|
||
# Offense count: 13 | ||
Metrics/AbcSize: | ||
Max: 51 | ||
|
||
# Offense count: 2 | ||
# Configuration parameters: CountComments. | ||
Metrics/ClassLength: | ||
Max: 120 | ||
|
||
# Offense count: 1 | ||
Metrics/CyclomaticComplexity: | ||
Max: 9 | ||
|
||
# Offense count: 1 | ||
Metrics/PerceivedComplexity: | ||
Max: 9 | ||
|
||
# Offense count: 17 | ||
# Configuration parameters: EnforcedStyle, SupportedStyles. | ||
Style/ClassAndModuleChildren: | ||
Exclude: | ||
- 'lib/mms/cli.rb' | ||
- 'lib/mms/resource/alert.rb' | ||
- 'lib/mms/resource/backup_config.rb' | ||
- 'lib/mms/resource/cluster.rb' | ||
- 'lib/mms/resource/group.rb' | ||
- 'lib/mms/resource/host.rb' | ||
- 'lib/mms/resource/metric.rb' | ||
- 'lib/mms/resource/restore_job.rb' | ||
- 'lib/mms/resource/snapshot.rb' | ||
- 'lib/mms/resource/snapshot_schedule.rb' | ||
|
||
# Offense count: 1 | ||
# Configuration parameters: Exclude. | ||
Style/FileName: | ||
Exclude: | ||
- 'bin/mms-api' | ||
|
||
# Offense count: 2 | ||
# Configuration parameters: MinBodyLength. | ||
Style/GuardClause: | ||
Exclude: | ||
- 'lib/mms/cli.rb' | ||
- 'lib/mms/resource.rb' | ||
|
||
# Offense count: 5 | ||
# Cop supports --auto-correct. | ||
Style/NumericLiterals: | ||
MinDigits: 9 | ||
|
||
# Offense count: 5 | ||
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. | ||
Style/PredicateName: | ||
Exclude: | ||
- 'lib/mms/resource/backup_config.rb' | ||
- 'lib/mms/resource/restore_job.rb' | ||
- 'lib/mms/resource/snapshot.rb' | ||
|
||
# Offense count: 3 | ||
# Configuration parameters: SupportedStyles. | ||
Style/RaiseArgs: | ||
EnforcedStyle: compact | ||
|
||
# Offense count: 27 | ||
# Configuration parameters: Exclude. | ||
Style/Documentation: | ||
Enabled: false | ||
|
||
# Offense count: 1 | ||
# Cop supports --auto-correct. | ||
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. | ||
Style/TrivialAccessors: | ||
Exclude: | ||
- 'lib/mms/resource.rb' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
language: ruby | ||
|
||
sudo: false | ||
rvm: | ||
- 2.0.0 | ||
- 1.9.3 | ||
- 2.0.0 | ||
- 2.2.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shortdudey123 I think this is a bug. I see that
rubocop
suggest to use==
but the bug is there from the beginning:)! We should useelse
instead ofelsif
otherwisedatetime
will be lost...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for fixing bugs :p
Something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, exactly like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed