Skip to content
This repository has been archived by the owner on Mar 19, 2018. It is now read-only.

Doesn't reconnect when pulsar server is restarted (WebSocket?) #10

Merged
merged 8 commits into from
May 8, 2015

Conversation

njam
Copy link
Member

@njam njam commented May 8, 2015

Reproduce:

  1. Start "pulsar-rest-api" server
  2. Start "hubot-pulsar" using this client
  3. Restart "pulsar-rest-api"
  4. When running jobs, there will be no success and no error event

@vogdb @tomaszdurka I assume the client doesn't reconnect properly?

@njam njam added the bug label May 8, 2015
@njam njam added the ready label May 8, 2015
@njam njam assigned njam and vogdb and unassigned vogdb and njam May 8, 2015
@njam njam added in progress and removed ready labels May 8, 2015
@njam njam assigned njam and unassigned vogdb May 8, 2015
@njam
Copy link
Member Author

njam commented May 8, 2015

@vogdb please review

@vogdb
Copy link
Contributor

vogdb commented May 8, 2015

lgtm

For some reason the "sockjs-client" (~1.0.0-beta.13) doesn't connect to our production pulsar-rest-api websocket server.
@njam
Copy link
Member Author

njam commented May 8, 2015

@vogdb please check (see commit msg)

njam added a commit that referenced this pull request May 8, 2015
Doesn't reconnect when pulsar server is restarted (WebSocket?)
@njam njam merged commit b068d79 into cargomedia:master May 8, 2015
@njam njam removed the in progress label May 8, 2015
@njam njam deleted the websocket-reconnect branch May 8, 2015 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants