Conversation
Thanks for the PR. Could you please squash the two commits? |
Sure, have done. |
Thanks! |
Is this sufficient for now, or do I need to push a new release? |
No need to do anything further. There is an override for the 1.4.0 release running here - https://github.com/jspm/registry/blob/master/package-overrides/github/carhartl/jquery-cookie%401.4.0.json So when the next release comes out, this won't be needed anymore. |
tanks!! |
We are planning to remove unpopular package managers in the upcoming version 2.0 on http://github.com/js-cookie/js-cookie. Recently we had custom code for a package manager but eventually it broke and nobody noticed. It turns out to be unpractical to support all package managers, so we are sticking to npm and bower. Is there a real issue in removing this custom code from the new renamed project's codebase? Can't we support this package manager in a way that it's not necessary to maintain custom code in the original repository? Thanks. |
@FagnerMartinsBrack sure you can remove the dated jspm configuration. To ensure that the package works through jspm I would suggest setting the main entry point on npm to |
Like this? https://github.com/js-cookie/js-cookie/blob/2f625ebbbfa91fa154a61152b7deea32659a0792/package.json#L5 I made a cross-reference from the pull request that originated that line. Comments are not allowed in the JSON spec so this is the only way to keep context of why that property exists. |
Ah right, so the current jspm configuration is actually overriding that and stopping it from working! Ie it will work when the jspm config is removed. |
With this package.json configuration, it is possible to load the plugin through jspm, like in the following example:
http://jsbin.com/Avufiyo/1/edit
The plugin is served minified with source maps over SPDY, with the AMD format automatically detected by the loader.
Would really appreciate not having to do a custom override for this functionality. Any questions just ask.