Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Argument Cluster #19

Closed
carl-hamlin opened this issue Oct 14, 2013 · 1 comment
Closed

Implement Argument Cluster #19

carl-hamlin opened this issue Oct 14, 2013 · 1 comment
Assignees
@carl-hamlin
Projects
Dig Command Egg Command Gylf Command Help Command Think Command Argument Cluster

Comments

@carl-hamlin
Copy link
Owner

Right now, we're manually figuring out arguments for commands within the code for the command itself.

Let's not do that. Instead, let's have a function to parse command arguments into a predictable format so we know what argument is where before executing command code.
@ghost ghost assigned carl-hamlin Oct 14, 2013
@carl-hamlin carl-hamlin added this to Server Side in Dig Command Feb 1, 2017
@carl-hamlin carl-hamlin added this to Server Side in Egg Command Feb 1, 2017
@carl-hamlin carl-hamlin added this to Server Side in Gylf Command Feb 1, 2017
@carl-hamlin carl-hamlin added this to Server Side in Help Command Feb 1, 2017
@carl-hamlin carl-hamlin added this to Server Side in Think Command Feb 2, 2017
@carl-hamlin carl-hamlin added this to Server Side in Argument Cluster Feb 3, 2017
carl-hamlin added a commit that referenced this issue Feb 5, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
074a31a 
Turns out there was a deep disconnect with regards to aggregating arguments and where those
arguments could in fact be found in the data received from the socket. This disconnect has
now been resolved.
carl-hamlin added a commit that referenced this issue Feb 5, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
52ac499 
Argument cluster wasn't counting arguments correctly, which was of course causing
problems for argument-dependent commands. It now counts arguments correctly, and
strips the actual command off of the argument cluster.
carl-hamlin added a commit that referenced this issue May 3, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
4ddddbf 
Issue #55: Think Command Should Direct to Named Participant Per Mental Projection Skill
Issue #67: Think Command Should Use Argument Cluster

Think command now uses Argument Cluster to aggregate arguments for
the process of identifying which socket to which to broadcast
targetted messages.
@carl-hamlin
Copy link
Owner Author

Argument Cluster is implemented and performing well under testing. Closing issue.

carl-hamlin added a commit that referenced this issue May 3, 2017
@carl-hamlin
Issue #19 Implement Argument Cluster
10da0e7 
Issue #55: Think Comand Should Direct to Named Participant per Mental Projection Skill
Issue #67: Think Command Should Use Argument Cluster

Goddammit - I left another breakpoint in the last commit.
carl-hamlin added a commit that referenced this issue May 4, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
94196a5 
Issue #313: Area Command Should Use Argument Cluster

Area command now makes use of the argument cluster to aggregate arguments.
carl-hamlin added a commit that referenced this issue Sep 22, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
99b2fb4 
Added branch description.
carl-hamlin added a commit that referenced this issue Sep 22, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
3153ec9 
Resolved apparent longstanding typo in argument.cluster that was,
unbelievably, showing up in master and halting the build. Talk
about a quality lapse.
carl-hamlin added a commit that referenced this issue Sep 22, 2017
@carl-hamlin
Issue #19: Implement Argument Cluster
46750d3 
We're back on track - removed branch description in preparation for
branch promotion to master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carl-hamlin carl-hamlin

Labels
None yet
Projects
Dig Command
Server Side
Egg Command
Server Side
Gylf Command
Server Side
Help Command
Server Side
Think Command
Server Side
Argument Cluster
Server Side
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carl-hamlin