swagger-ui-dist has a really slow require #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some issues inside swagger-ui-dist the following require code adds around 300-500ms of latency:
const SWAGGER_UI_PATH = require('swagger-ui-dist').getAbsoluteFSPath();
Solution is to import absolute-path.js directly
A ticket exists on the swagger-ui-dist project swagger-api/swagger-ui#4502
This change makes it resolve in 0.122ms on my system so about 3 orders of magnitude better.
Additionally: updated all dependencies
Part of internal ticket: SRV-154