Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VIDEO-RANGE attribute #11

Closed
simonerni opened this issue Apr 20, 2020 · 3 comments
Closed

Support VIDEO-RANGE attribute #11

simonerni opened this issue Apr 20, 2020 · 3 comments

Comments

@simonerni
Copy link
Contributor

Hi Anton,

After packaging my media with the Shaka Packager and trying to parse the resulting m3u8 with this parser, it throws the exception

io.lindstrom.m3u8.parser.PlaylistParserException: Unknown key VIDEO-RANGE

VIDEO-RANGE is an attribute in a draft of RFC 8216 and has the values "PQ" or "SDR":
https://tools.ietf.org/html/draft-pantos-hls-rfc8216bis-06

Is it possible to add this attribute? I'll create a pull request for it as well.

@carlanton
Copy link
Owner

Hi Simon,

Never heard of VIDEO-RANGE before, but I did understand some of the words in RFC describing it. :)

It looks like the attribute also can be used for EXT-X-I-FRAME-STREAM-INF. Do you want to add that, or is shaka packager not using that?

Thanks,
Anton

simonerni added a commit to simonerni/m3u8-parser that referenced this issue Apr 20, 2020
@simonerni
Copy link
Contributor Author

simonerni commented Apr 20, 2020

Hi Anton,

Thanks for the quick response!

Yeah it's very confusing - the linked reference to the ISO standard does not help either, as you'd need to buy the standards document to even access the relevant section (TransferCharacteristics). As I understood it, it tells the player that the variant is a variant displayable by any screen (SDR) or it defines some colors that are not understood (any color range commonly referred to as HDR) and marks this with VIDEO-RANGE=PQ.

Kind Regards,
Simon

carlanton added a commit that referenced this issue Apr 21, 2020
#11 Added support for VIDEO-RANGE attribute for Variants
@carlanton
Copy link
Owner

Merged and released! Version 0.10 should be out on maven.org in an hour or so.

Thanks,
Anton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants