Format code #53
Open
Format code #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great request. I mainly hesitated to enforce the linting, because of URIs in docstrings, such as: that break max line length rule. I wasn't able to come up with a good fix for that up to this point. How is this handled here? Besides, I was also a bit lazy with formatting at some point, as you already have noticed, while the contribution guideline expects us to actually care about it.So all in all: Great initiative, highly appreciated. As discussed in #54 (comment), I have a few more things that I like to add. Therefore I'd suggest to wait with this just for a little and then do the reformatting in a single pass. |
|
Cheers! :) Black did not touch these long docstrings, but fixes many other things. If you are worried about merge conflicts, just accept your own changes and let pre-commit handle reformatting everything again. That way, these changes can get merged quickly for the CI benefit. |
# Conflicts: # requirements_dev.txt # setup.py # timeseriesx/__init__.py # timeseriesx/base/timestamp_series.py # timeseriesx/mixins/time_zone.py # timeseriesx/mixins/unit.py
# Conflicts: # setup.py # tests/test_timeseriesx.py # timeseriesx/base/timestamp_series.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52.