-
Notifications
You must be signed in to change notification settings - Fork 812
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pure ruby installer for vimball archives
- Loading branch information
Showing
1 changed file
with
27 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ae5611
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with this line:
A lot of vimballs don't have that garbage at the end. The following code is more similar to vimball itself and works for all vimballs on vim-scripts.org:
That last line is because 16 vimballs separate paths with .
By the way, great idea! It's really improved the vim-scripts.org scraper. vim-scraper/vim-scraper@f395205#L0R900
6ae5611
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Any chance you can submit a patch/pull-request, or just open a ticket so I don't forget about this.
6ae5611
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up committing fe8e7a9, thanks!