Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

Fix on_commit execution order when callbacks make transactions #25

Closed
wants to merge 1 commit into from

Conversation

craigds
Copy link

@craigds craigds commented Mar 23, 2017

Backport of django/django@a5c8072

@coveralls
Copy link

Coverage Status

Coverage decreased (-23.6%) to 76.364% when pulling cb27f9b on craigds:master into a3eabdd on carljm:master.

@craigds
Copy link
Author

craigds commented Mar 23, 2017

wow. unfortunately I'm a bit at a loss where to begin with that sqlite failure. Clearly it works in django 1.9 but I'm unclear why.

@carljm
Copy link
Owner

carljm commented Mar 23, 2017

That error message still exists in Django today (https://github.com/django/django/blob/master/django/db/transaction.py#L153). Best I can suggest is to use pdb to trace through execution of that test in Django 1.10 (it wasn't added in 1.9), and also in 1.8 with django-transaction-hooks and this patch, to figure out what is different.

@carljm carljm closed this Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants