Associate sockets with a Selector
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #308 Windows requires that sockets are used exclusively with a single IOCP handle. Unix platforms do not have this requirement. In order to provide a cross platform API, Mio's network types artificially impose this limitations on Unix platforms. If a user of Mio would like to use a single socket with multiple event loops on Unix platforms, this is possible by using `std::net` types and the `EventedFd` wrapper.
| @@ -14,11 +15,13 @@ use sys::unix::eventedfd::EventedFd; | |||
| #[derive(Debug)] | |||
| pub struct TcpStream { | |||
| inner: net::TcpStream, | |||
| selector_id: Cell<Option<usize>>, | |||
There was a problem hiding this comment.
This has the consequence of making the types not Sync, which perhaps isn't desired? Concurrently reading/writing with a TcpStream may be useful in some cases.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308
Windows requires that sockets are used exclusively with a single IOCP handle.
Unix platforms do not have this requirement. In order to provide a cross
platform API, Mio's network types artificially impose this limitations on Unix
platforms.
If a user of Mio would like to use a single socket with multiple event loops
on Unix platforms, this is possible by using
std::nettypes and theEventedFdwrapper./cc @alexcrichton