Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt missing in pypi release #216

Closed
blkmajik opened this issue Feb 18, 2022 · 4 comments
Closed

requirements.txt missing in pypi release #216

blkmajik opened this issue Feb 18, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@blkmajik
Copy link

Describe the bug
setup.py requires the use of requirements.txt, but it is missing from the pypi sdist file.

To Reproduce
build from sdist source

python3 setup.py build

Expected behavior
project would bulid properly

Stack Trace
Traceback (most recent call last):
File "setup.py", line 13, in
with open("requirements.txt", "r", encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'

OS (please complete the following information):

  • OS: CentOS 7

Additional context

@blkmajik blkmajik added the bug Something isn't working label Feb 18, 2022
@carlmontanari
Copy link
Owner

Good catch. Happen to know the "best" way to include nowadays? Is it still MANIFEST.in or is there something nicer/better that works w/ standard setup.py stuff?

Thanks!

Carl

@blkmajik
Copy link
Author

Yeah as far as I know it's still MANIFEST.in if you are using setup.py

@carlmontanari
Copy link
Owner

Cool, thanks! I'll poke around with that this weekend hopefully. Unless its critical for ya for some reason I probably won't bother with cutting a new release again till the "regularly scheduled" cycle (1/30 and 7/30).

@carlmontanari
Copy link
Owner

Thanks again for raising this, will merge #217 to develop here in a sec -- it includes manifest.in grabbing all the requirements files! Like I said, won't make another release until 7/30, unless you have some burning need (in which case I can just push out a post release to 1/30 version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants