cmd/*-sync: avoid clobbering existing user installations

If a user already has an existing version installed, let's avoid deleting it.
carlocab · Apr 26, 2024 · dde493c · dde493c
1 parent f5cde8a
commit dde493c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/Library/Homebrew/cmd/nodenv-sync.rb b/Library/Homebrew/cmd/nodenv-sync.rb
@@ -58,6 +58,8 @@ def link_nodenv_versions(path, nodenv_versions)
         (0..minor_version).each do |minor|
           (0..patch_version).each do |patch|
             link_path = nodenv_versions/"#{major_version}.#{minor}.#{patch}"
+            # Don't clobber existing user installations.
+            next if link_path.exist? && !link_path.symlink?
 
             FileUtils.rm_f link_path
             FileUtils.ln_sf path, link_path

diff --git a/Library/Homebrew/cmd/pyenv-sync.rb b/Library/Homebrew/cmd/pyenv-sync.rb
@@ -56,6 +56,8 @@ def link_pyenv_versions(path, pyenv_versions)
 
         (0..patch_version).each do |patch|
           link_path = pyenv_versions/"#{major_version}.#{minor_version}.#{patch}"
+          # Don't clobber existing user installations.
+          next if link_path.exist? && !link_path.symlink?
 
           FileUtils.rm_f link_path
           FileUtils.ln_sf path, link_path

diff --git a/Library/Homebrew/cmd/rbenv-sync.rb b/Library/Homebrew/cmd/rbenv-sync.rb
@@ -57,6 +57,8 @@ def link_rbenv_versions(path, rbenv_versions)
 
         (0..patch_version).each do |patch|
           link_path = rbenv_versions/"#{major_version}.#{minor_version}.#{patch}"
+          # Don't clobber existing user installations.
+          next if link_path.exist? && !link_path.symlink?
 
           FileUtils.rm_f link_path
           FileUtils.ln_sf path, link_path