Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of element sections #332

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Eveliyse
Copy link

@Eveliyse Eveliyse commented Jan 2, 2024

I was looking at using this plugin and ran across the same problem described in #330 (mainly I don't use the tasks but found the empty card to be taking up precious screen real estate). I set out to fix this problem for myself but thought it might be a good idea to contribute what I've done back to the codebase but as I was tidying up the code I realised that what I had implemented may not fit the current design philosophy.

I started changing/adding many things and eventually decided to pause and ask for clarification here!

Changes I've currently made:

  • Added settings to toggle task and relationship card visibility for each element type
    • This is non-destructive in that no tasks/relationships are deleted (so they will still appear in searches)
  • Made the attribute card not display for an element if it has no attributes to display
  • Made the relationship card not display for an element if it has no relationships to display
  • Added the ability to add a task via the options pane
  • Made the task card not display for an element if it has no relationships to display

I think I am leaning towards removing the settings since just having the cards not display if they are empty already fix the "empty cards take up room" problem. I am happy to make different changes though if the path I've started down is the wrong one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant