PHPStan throws violation on accessing ->because() after ->excluding()

[dkreuer]

Bug Description
Running PHPat as documented while validating test files with PHPStan throws violation, accessing ->because() after ->excluding() because ->excluding() returns a TipOrBuildStep but is annotated to return a BuildStep, making calling ->because() polymorphic and therefore invalid.

Additional context

<?php
// tests/Module/Iam/Architecture/DisallowModuleAccess.php

declare(strict_types=1);

namespace App\Module\Iam\Tests\Architecture;

use PHPat\Selector\Selector;
use PHPat\Test\Builder\Rule;
use PHPat\Test\PHPat;

final class DisallowModuleAccess
{
    public function test_module_only_accesses_other_modules_public_api(): Rule
    {
        return PHPat::rule()
            ->classes(Selector::inNamespace('App\\Module\\Iam\\Application'))
            ->shouldNotDependOn()
                ->classes(
                    Selector::inNamespace('App\\Module'),
                )
                ->excluding(
                    Selector::inNamespace('App\\Module\\Iam'),
                    Selector::inNamespace('/^App\\\\Module\\\\(.*?)\\\\Presentation\\\\Php/', true),
                )
                ->because('modules must not depend on other modules internals');
    }
}

results in

 ------ ---------------------------------------------------------------------- 
  Line   tests/Module/Iam/Architecture/DisallowModuleAccess.php                
 ------ ---------------------------------------------------------------------- 
  15     Call to an undefined method PHPat\Test\Builder\BuildStep::because().  
 ------ ---------------------------------------------------------------------- 

Proposed solution
By changing the signature of ->excluding() to return TipOrBuildStep the polymorphic call goes away. I'm happy to provide a PR for that change.

[carlosas]

Good catch!
I can make the fix now, since there is a feature waiting to be released.

Thanks for the heads up :D

[carlosas]

Fixed with https://github.com/carlosas/phpat/releases/tag/0.10.10 🚀