created script to build the phar and updated compify.phar #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any chance to get the pull request accepted? |
carlosbuenosvinos
added a commit
that referenced
this pull request
Dec 15, 2015
created script to build the phar and updated compify.phar
|
Done! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the issue I had opened, I cloned the repositry and check if the error is in the compify code or somewhere else.
Quickly I figured out that the compify code is working with "up to date" sources.
Since the "self-update" is downloading a three year old file, I was willing to create a new compify.phar file.
To easy up repeating this task, I created a build script.
A little bit strange was the fact, that the '$cleanCommands' are not working anymore. Thats why I replaced this with an, hopefully equal in speed and result, command.
All in all, I could only write "it is working on my machines".
Kind regards and thanks for the tool so far. I would like to introduce this in my company.