Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in team reviewers input parameter #96

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jeslat
Copy link
Contributor

@jeslat jeslat commented Mar 22, 2023

There was a typo in the team reviewers input parameter which cause it didn't work.

This change will break the retro-compatibility with previous versions if someone is adding team reviewers using teamReviewers parameter. The option to maintain it is changing the parameter name to teamReviewers, I can do it if you prefer this second option.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, maintenance

@jeslat
Copy link
Contributor Author

jeslat commented Apr 17, 2023

Hi @carloscastrojumo, could you review this PR?

@carloscastrojumo carloscastrojumo added the bug Something isn't working label Mar 26, 2024
@carloscastrojumo
Copy link
Owner

Thank you for the fix @jeslat

@carloscastrojumo carloscastrojumo merged commit 7bd20ca into carloscastrojumo:main Mar 26, 2024
3 checks passed
@jeslat jeslat deleted the fix-team-reviewers branch March 27, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants