Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using unicode instead of :emoji: #14

Closed
carloscuesta opened this issue Nov 24, 2016 · 3 comments
Closed

Consider using unicode instead of :emoji: #14

carloscuesta opened this issue Nov 24, 2016 · 3 comments

Comments

@carloscuesta
Copy link
Owner

carloscuesta commented Nov 24, 2016

Consider using unicode instead of :emoji:

Referring to that issue

Changes that needs to be made to use unicode instead of :emoji:

{
	choices: gitmojis.map(gitmoji => {
		return {
			name: `${gitmoji.emoji}  - ${gitmoji.description}`,
+			value: gitmoji.code
		};
	})
}
{
	choices: gitmojis.map(gitmoji => {
		return {
			name: `${gitmoji.emoji}  - ${gitmoji.description}`,
-			value: gitmoji.emoji
		};
	})
}
@posva
Copy link
Contributor

posva commented Feb 2, 2017

For those wanting to apply the local change, the file that needs to be modified is src/gitmoji.js

@posva
Copy link
Contributor

posva commented Feb 2, 2017

Hey, what about having this option and maybe more in the future in some config (I'd rather add it to the packaged) using something like cosmiconfig
Other possible options is omitting questions like the sign commit question

@carloscuesta
Copy link
Owner Author

Will take a look at cosmiconfig @posva 👍

carloscuesta added a commit that referenced this issue Mar 4, 2017
Add option to disable the auto add and the way that gitmojis should be used. Fixes #28 and #14.

Signed-off-by: Carlos Cuesta <carloscuesta@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants