Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: #39

Closed
wayneashleyberry opened this issue Apr 13, 2017 · 9 comments
Closed

ERROR: #39

wayneashleyberry opened this issue Apr 13, 2017 · 9 comments
Labels

Comments

@wayneashleyberry
Copy link
Contributor

Hello @carloscuesta!

Trying to use the gitmoji cli for the first time and it's not really working :/

OS: macOS 10.12.4
gitmoji-cli -v: 1.5.0
Node version: v7.9.0

Error Message:

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gs
## master...origin/master
 M readme.md

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji
? Choose a gitmoji: 💡  - Documenting source code.
? Enter the commit title: Docs
? Enter the commit message: Testing gitmoji...
? Issue / PR reference #:
? Signed commit: Yes
ERROR:

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   readme.md

no changes added to commit (use "git add" and/or "git commit -a")

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -c
? Choose a gitmoji: 📝  - Writing docs.
? Enter the commit title: Writing docs.
? Enter the commit message: Just playing around with gitmoji really...
? Issue / PR reference #:
? Signed commit: Yes
ERROR:
@carloscuesta
Copy link
Owner

🤔 Can you try to install the 1.4.0 version to see if you've got the same issue?

@wayneashleyberry
Copy link
Contributor Author

Same problem with 1.4.0 @carloscuesta :(

Is there perhaps a verbose flag or debug environment variable I could set?

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -v
1.4.0

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -c
? Choose a gitmoji: (Use arrow keys)
❯ 🎨  - Improving structure / format of the code.
  ⚡️  - Improving performance.
  🔥  - Removing code or files.
  🐛  - Fixing a bug.
  🚑  - Critical hotfix.
  ✨  - Introducing new features.
  📝  - Writing docs.
(Move up and down to reveal more choices)

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -c
? Choose a gitmoji: 📝  - Writing docs.
? Enter the commit title: Writing docs.
? Enter the commit message: Just testing out gitmoji.
? Issue / PR reference #:
? Signed commit: Yes
ERROR:

@carloscuesta
Copy link
Owner

carloscuesta commented Apr 13, 2017

There's no debug flag but I'm taking a look into it to fix this issue @wayneashleyberry

Before using gitmoji -c did you run gitmoji -i ?

@wayneashleyberry
Copy link
Contributor Author

Nope, I haven't run gitmoji -i at all.

@carloscuesta
Copy link
Owner

carloscuesta commented Apr 13, 2017

Another thing I have in mind, try to run gitmoji -g and answer y to the autoadd question, by default it's set to false. Then try to commit 🤔 @wayneashleyberry

screen shot 2017-04-13 at 15 15 44

@wayneashleyberry
Copy link
Contributor Author

My changes weren't staged - so there was nothing to commit 🤦‍♂️

I feel like gitmoji should pick that up first maybe? Or maybe a better error message would help.

Git complains about this, and I feel gitmoji should have the same behaviour as it's almost a replacement for git commit

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git commit -m 'foo'
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
	modified:   readme.md

no changes added to commit
~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   readme.md

no changes added to commit (use "git add" and/or "git commit -a")

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git add readme.md

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

	modified:   readme.md


~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -c
? Choose a gitmoji: 📝  - Writing docs.
? Enter the commit title: Writing docs.
? Enter the commit message: Just playing with gitmoji-cli!
? Issue / PR reference #:
? Signed commit: Yes
[master 8718f2f] :memo: Writing docs.
 1 file changed, 2 insertions(+)

@carloscuesta
Copy link
Owner

carloscuesta commented Apr 13, 2017

Yes totally!

In fact this issue comes from implementing the feature ebce5ff. We have to set a default value for that.

This is something that the cli should handle, thanks for taking your time to report this issue ❤️

By the way this is related with #37

carloscuesta added a commit that referenced this issue Apr 13, 2017
 #39

Signed-off-by: Carlos Cuesta <carloscuesta@me.com>
@carloscuesta
Copy link
Owner

carloscuesta commented Apr 13, 2017

Released 🎉 @ v1.5.1 @wayneashleyberry

@wayneashleyberry
Copy link
Contributor Author

Thanks for that @carloscuesta :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants