馃悰 Fix access mode of prepare-commit-msg #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that with fs.writeFile, the mode option needs to be specified as an octal number. I determined this after running `gitmoji -i`, and having the file created with very strange permissions: ``` $ stat .git/hooks/prepare-commit-msg File: '.git/hooks/prepare-commit-msg' Size: 70 Blocks: 8 IO Block: 4096 regular file Device: fd03h/64771d Inode: 19398811 Links: 1 Access: (1361/--wxrw---t) Uid: ( 1000/ grdryn) Gid: ( 1000/ grdryn) Context: unconfined_u:object_r:container_file_t:s0 Access: 2016-11-26 02:19:14.661093296 +0000 Modify: 2016-11-26 02:19:14.661093296 +0000 Change: 2016-11-26 02:19:14.661093296 +0000 Birth: - ``` The docs[1] for this function give the default example as being in octal, and when I changed it and tried it out, it worked much better. In addition, the rest of the files in `.git/hooks/` appear to have mode `775` rather than `755`, so I changed this here to match that also. [1] https://nodejs.org/dist/latest-v7.x/docs/api/fs.html#fs_fs_writefile_file_data_options_callback
grdryn
changed the title
|
Cool thanks for that @grdryn! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that with fs.writeFile, the mode option needs to be specified as an octal number. I determined this after running
gitmoji -i, and having the file created with very strange permissions:The docs[1] for this function give the default example as being in octal, and when I changed it and tried it out, it worked much better.
In addition, the rest of the files in
.git/hooks/appear to have mode775rather than755, so I changed this here to match that also.[1] https://nodejs.org/dist/latest-v7.x/docs/api/fs.html#fs_fs_writefile_file_data_options_callback