Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Cli refactor #222

Merged
merged 42 commits into from Nov 6, 2019
Merged

♻️ Cli refactor #222

merged 42 commits into from Nov 6, 2019

Conversation

carloscuesta
Copy link
Owner

@carloscuesta carloscuesta commented Oct 27, 2019

This PRs is a major refactor for gitmoji-cli. I'm changing the architecture of the code and improving aswell the UX and the Developer UX for contributors.

This will be released in a major version since we're dropping support for Node.js 6 and 8. The minimum required version will be 10.

@carloscuesta carloscuesta self-assigned this Oct 27, 2019
@carloscuesta carloscuesta added this to the 3.0.0 milestone Oct 27, 2019
@carloscuesta carloscuesta force-pushed the cli-refactor branch 9 times, most recently from 486300b to e53edcc Compare November 2, 2019 10:11
@carloscuesta carloscuesta force-pushed the cli-refactor branch 2 times, most recently from f1228c2 to 79dad16 Compare November 2, 2019 10:23
@carloscuesta
Copy link
Owner Author

Whole code is refactored, we need to made all the tests again 👀

@carloscuesta carloscuesta marked this pull request as ready for review November 6, 2019 18:48
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #222 into master will increase coverage by 31.73%.
The diff coverage is 86.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #222       +/-   ##
===========================================
+ Coverage   54.59%   86.33%   +31.73%     
===========================================
  Files           7       20       +13     
  Lines         174      139       -35     
  Branches       28       20        -8     
===========================================
+ Hits           95      120       +25     
+ Misses         65       15       -50     
+ Partials       14        4       -10
Impacted Files Coverage Δ
src/utils/findGitmojiCommand.js 100% <100%> (ø)
src/commands/hook/hook.js 100% <100%> (ø)
src/commands/config/prompts.js 100% <100%> (ø)
src/utils/emojisCache.js 100% <100%> (ø)
src/utils/configurationVault.js 100% <100%> (ø)
src/cli.js 100% <100%> (ø)
src/commands/config/index.js 100% <100%> (ø)
src/utils/printEmojis.js 100% <100%> (ø)
src/commands/commit/index.js 100% <100%> (ø)
src/commands/update/index.js 100% <100%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086050d...7716ba9. Read the comment docs.

Copy link
Owner Author

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming in 🚀

@carloscuesta carloscuesta merged commit 77b4e56 into master Nov 6, 2019
@carloscuesta carloscuesta deleted the cli-refactor branch November 6, 2019 21:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant