Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hook abord on amend #507

Conversation

Jeremie-Chauvel
Copy link
Contributor

@Jeremie-Chauvel Jeremie-Chauvel commented Dec 7, 2020

Description

I implemented interruption of the hook on git commit --amend while investigation yarn version command. I recommand reading the linked issue for a more in depth summary of why yarn release is not compatible with gitmoji

Issue: linked to #497

Tests

  • All tests passed.
  • I added a test and fixed previous ones

ps: love the migration to github actions ❤️

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #507 (4f458d0) into master (394de23) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   89.69%   90.17%   +0.47%     
==========================================
  Files          22       22              
  Lines         165      173       +8     
  Branches       24       25       +1     
==========================================
+ Hits          148      156       +8     
  Misses         14       14              
  Partials        3        3              
Impacted Files Coverage Δ
src/commands/hook/hook.js 100.00% <ø> (ø)
src/commands/commit/index.js 100.00% <100.00%> (ø)
src/commands/commit/withHook/index.js 92.00% <100.00%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394de23...4f458d0. Read the comment docs.

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question!

Thanks for the pr ❤️

src/commands/hook/hook.js Show resolved Hide resolved
Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this

Thanks <3

@carloscuesta carloscuesta merged commit 420ca72 into carloscuesta:master Dec 9, 2020
@Jeremie-Chauvel Jeremie-Chauvel deleted the implement-hook-abord-on-amend branch December 9, 2020 09:20
carloscuesta added a commit that referenced this pull request Dec 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants