Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "highlight" emojies to landing page #347

Closed
JesseKPhillips opened this issue Oct 10, 2019 · 5 comments
Closed

Add "highlight" emojies to landing page #347

JesseKPhillips opened this issue Oct 10, 2019 · 5 comments

Comments

@JesseKPhillips
Copy link

JesseKPhillips commented Oct 10, 2019

Hello @carloscuesta 😎!

I would like to suggest a feature for the main landing page: https://gitmoji.carloscuesta.me/

I believe that different projects would find different emojies valuable over other projects (android has no value if you aren't targeting it). We tend to use

  • sparkles (feature)
  • bug
  • construction (architecture)
  • checkmark (test)
  • boom (breaking)
  • wrench (config)

Now I believe these are generally more useful and good to statically place on the top of the page, but this proposal is to add a query string (and instructions for use) that allows for this "highlighting"

?q=sparkles&q=bug

I suggest 'q' as it follows search engine practice and it could be consider asking a question.

?q=feature

This could then become a way for people to find what icon to use based on function instead of icon.

@smolijar
Copy link

Thanks for suggestion @JesseKPhillips

I completely agree. There's lots of them and its kind of difficult to get the hang of using gitmoji properly. At this point we have no data to make this happen.

I tried to propose a draft, which could serve as a foundation for this in #352

Thanks ❤️

@SkyaTura
Copy link
Contributor

Also on this subject, would be nice if we had tags on gitmoji data schema, that would allows us to search by categories easily on gitmoji-cli too.

@johannchopin
Copy link
Collaborator

Seems to be the exact description of my PR #438 (I didn't see this issue before open mine 😓). Sadly @carloscuesta don't like the idea of this feature.

@johannchopin johannchopin pinned this issue May 31, 2020
@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

I think resolving #405 would solve the peoblem raised in this issue.

@johannchopin
Copy link
Collaborator

You're right lets centralise this discussion in #405 👍

@johannchopin johannchopin unpinned this issue May 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants