Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Scrolling to the gitmoji matching the 'gitmoji' query parameter #438

Closed
johannchopin opened this issue May 31, 2020 · 9 comments
Closed

Comments

@johannchopin
Copy link
Collaborator

Hello @carloscuesta 😎!

Implement this feature will make the sharing of a gitmoji easier. Going to https://gitmoji.carloscuesta.me/ show all the gitmojis but going to https://gitmoji.carloscuesta.me/?gitmoji=robot will scroll the page until the :robot: gitmoji and blur the other as you can see bellow:

View of the working feature

I'm using a blur effect to highlight the matching gitmoji but this can be changed with a better idea if you don't like it.

So for the feature:

  • If user enter a valid gimoji's name it will scroll until his card
  • If gimoji's name is invalid, the website is behaving normally (like without the query parameter)

Idea for the future:

  • Add a sharing link to each gitmoji
@carloscuesta
Copy link
Owner

Hey @johannchopin

I don't see this feature really friendly for users. It might be helpful to share a specific gitmoji, but you'll be pointed to the whole row not the specific one.

Also it's a tricky thing for users since they have to be playing with query-string parameters

I would not introduce this as a feature on the website 😊

@johannchopin
Copy link
Collaborator Author

I get your point that's not really user friendly to write a query-string parameter. I initially thought I'd implement it using a url variable like /robot but I wanted to keep it simple and not create a new page for it. So I wanted to reproduce the simple behaviour of an anchor like /#robot.

Is the blur effect not enought to highlight the right gitmoji?

Thanks for advice @carloscuesta 😉

@carloscuesta
Copy link
Owner

It’s just not the blur effect. The whole feature I think is confusing for the final user first for the interaction that depends on adding a query string to URL and then for seeing a blurred paged without knowing exactly what’s going on if you don’t know this specific behaviour

I don’t think we need to have this feature on the website IMHO

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

I, also, don't see the point for that feature. Why would I want to share a emoji?

but if you wanna make the feature friendlier to the user, you could add a search field for filtering and have a query string with the field content to be shared.

There is another issue behind this, do we want to have enough emojis for justifying a search or share feature? What are we aiming for? A no-tools commit framework or a tooled one?

The more emojis we add, the worse is for newcomers to know every one by heart, and I'd say gitmoji is more effective if we all know them without having to consult this site every time :D

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

There is also this other issue that, imho, is a better user experience #405


(kinda out of scope, but anyway:)
for related emojis, we could have another json file with like related emojis

{
  ...
  "bug": ["ambulance", "green_heart", ...]
}

@carloscuesta
Copy link
Owner

Yeah let's work on #405. Would be nice to have like a "toolbar" under the header before the gitmojis

Screenshot 2020-05-31 at 17 09 16

With like a searchbar and some sorting fields ?

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

Yeah let's work on #405. Would be nice to have like a "toolbar" under the header before the gitmojis

Screenshot 2020-05-31 at 17 09 16

With like a searchbar and some sorting fields ?

Yeah, I think a good benchmark would be how font-awesome handles their search :D
https://fontawesome.com/icons

@johannchopin
Copy link
Collaborator Author

johannchopin commented May 31, 2020

@vhoyer Is it really necessary to have a searchbar for that number of gitmojis? 🤔

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

you are right, provably just the categories are well enough 🤔

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants