New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finished the localization for Simplified Chinese, wish to join the contributor party #560
Comments
Hey @nekomeowww 👋 Open an issue is the best way to contact a contributor 😉 Localisation is a nice topic for gitmoji (many peoples ask for it) but it make then the project harder to maintain (if you change a sentence, you will need to change all the sentence in each 'supported' language). But IMHO it's possible to handle it in a project with +8k⭐. I already implemented localisation in multiple projects but I will first wait for the opinion of @carloscuesta. |
Sure happy to be heard that. |
having localization would be awesome, although it would really make it difficult, haha 🤔 I will give an idea here, but I think it's not a great idea, but we can maybe work from there (considering we will indeed follow up on internationalizing the website). We could add, in each language, the version that language is current representing, so the english (global) mainteined by all of us will be the, like One problem I can expect happening is having several threads that are non-english, which would be kinda hard to maintain, but, as a possible solution I just thought of, we could have issues dedicated to a language translation like Well, it will be difficult, so I donno if it would be feasible, anyway, let's wait more opinions on this :D |
It's wonderful to have your words here. For me, I have worked around for many project's localization functionalitie, cause Chinese is not the common language for people to use the service online, my projects, and the joined ones always have the ability to have a different language switcher. As for the problem you have said here.
You can have the default English native words in your document, import the target language if accessible, this may be one of the workarounds for that. Anyways, since I have deployed the Simplified Chinese version online, my friends and many users are using it for now. |
I have also an idea of how to maintain this stuffs. Lets say we will have a folder
Each of theses translations files are a {
"version": string,
"translations": {
"key": "sentence",
...
}
} We will say that the Then we can add a
With theses indicator in the To finish, it can be easy to create an So if someone update a translations, it has to run this script locally and push the generated What your opinion on this approach? |
A great idea to have.
This is definitely true for the localization process since this project is as user sponsor and contributable project, there might be many changes that needs to be done. |
The problems I see with the i18n of the site are:
That's why I not decided yet to translate the whole project. I understand that some users could feel confused as the project is not translated into their own language. The project now has an "easy to" contribute status. Adding i18n will add a lot of complexity to that process. Especially if anyone who wants to add a gitmoji should translate the description title and name to every language that is on the project. Considering that is an OSS project, no one should be tied to it. We invest our free time on doing this, so you can't expect to make someone work on this to help with the translation issues. |
@carloscuesta I guess that if a user add or modify something, he should first only do it in english (and makes some translations if he want). With the process explained in #560 (comment), the README will show some fancy critical badge which could easily catch developer intention: In the OSS world there are a lot of developer that invest their time by fixing typo or doing 'maintenance' stuffs. So I guess with gitmoji we will find some guys with interest in translating sentences ;) |
@johannchopin For me it's not an option for a Pull Request to include the english language and leave the other supported languages empty. If you offer i18n on a project do it right, or don't offer a solution. Because the UX of the other languages would be really poor, because you'll find that there are a lot of translations that are missing and you'll find some Gitmoji cards empty on languages that are not english. I think we should find something that does not depends on contributions and we need to find a way to automate this. Because depending on contributors and humans it's not a scalable solution. Also the approach you provided at #560 (comment) it's not bad but I don't quite like the |
There is no way to automate translations unless you don't care about quality. |
well, all this is true. Maybe we could make it easier for people like @nekomeowww to create forks with translations and or you could work on an automated issue that would notify the interested people that the gitmoji.json changed texts. Like, every time there is a change in a description we could add a message in this issue to let people that have translation forks to know easily that there was a change? Just an ideia, I don't even know if this is a real problem 😓 |
Yes. Also if you really want to absolutely enforce up to date translations, you can make the brutal choice of automatically hiding languages that are incomplete or not updated. But at least localization will be implemented. |
I'm interested in making french translation. What's the status for the technical implementation of i18n on Gitmoji ? |
The technical implementation is not the problem. It's really easy to add I don't see a clear path right now for making this automatically. Until we didn't figure out a solution for this I won't move towards introducing
|
Well, I offered you the solution
Also
|
This is not a good solution. Because the translations will not be visible to the user so you're making a lot of work to not provide any real value.
|
Hello @carloscuesta 😎!
Several days ago I forked your repo here and created the new one as the source repo: https://github.com/nekomeowww/gitmoji-zhcn
And I finished the Simplified Chinese localization with the new site deployed on this repo: https://github.com/nekomeowww/gitmoji
Which is powered by GitHub Pages to the brand new site for Chinese: https://neko.ayaka.moe/gitmoji/
I wish to know a way to join one of the collaborators here. Since I have my contribution to my repo.
Or we can work out a way to make more internationalization possible throughout the browser detection or user selection.
The text was updated successfully, but these errors were encountered: