[WIP] Add ability to change gitmojis order #391
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
select
which allow users to change the order in which gitmojis are displayed.Feature was implemented using
useState
hook and do not interfere with current order which stays default (so if you are used to it everything is on the same place 馃槃).For sure UI can be implemented better but I was trying to mimic current design and do not include new layout structures (I also was thinking about adding this
select
right above gitmojis, on the white part of page, but finally I decided to go withbutton
approach).And of course I'm open to refine this PR if any feedback or request arises.
P.S. I also have extracted
font-family
to the SCSS variable.Tests