Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ability to change gitmojis order #391

Closed
wants to merge 5 commits into from

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 13, 2019

Description

This PR adds select which allow users to change the order in which gitmojis are displayed.

Feature was implemented using useState hook and do not interfere with current order which stays default (so if you are used to it everything is on the same place 馃槃).

For sure UI can be implemented better but I was trying to mimic current design and do not include new layout structures (I also was thinking about adding this select right above gitmojis, on the white part of page, but finally I decided to go with button approach).

And of course I'm open to refine this PR if any feedback or request arises.

Dec-14-2019 00-37-47

P.S. I also have extracted font-family to the SCSS variable.

Tests

  • New tests added.
  • All tests passed.

@Simek Simek changed the title Add ability to change gitmojis order [WIP]] Add ability to change gitmojis order Dec 14, 2019
@Simek Simek changed the title [WIP]] Add ability to change gitmojis order [WIP] Add ability to change gitmojis order Dec 14, 2019
@Simek
Copy link
Contributor Author

Simek commented Dec 14, 2019

@carloscuesta Three more things that are worth mentioning:

  • 馃攢 is not looking good on Windows, probably it would be better using <Icon /> here
  • of course pure HTML select can be replaced with react-select if needed
  • Add simple text search in the site聽#384 - if is a valid problem and feature is wanted I think I can also add like text field in this PR (and move both components directly above gitmojis list)

@johannchopin
Copy link
Collaborator

johannchopin commented May 31, 2020

I think a better way to implement it would be to use a draggable list of all gitmojis that the user can sort (easy to implement using react-sortable-hoc). Just store then the new order in the localStorage and that was 馃帀.

What do you think about this idea @Simek? 馃槂

@Simek
Copy link
Contributor Author

Simek commented May 31, 2020

@johannchopin I have lost interest in this change quite a while ago. Feel free to close this PR and implement order feature as you suggested.

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2020

Then, maybe we could follow the #405 again for this one, let's centralize the discussion around this feature there :D

@johannchopin
Copy link
Collaborator

@Simek Thanks a lot for your work and time and sorry for the (too) long reponse time 馃憤

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants