-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search emoji #411
Feature/search emoji #411
Conversation
i fixed a bug : on load there were no emojis |
related to #405 |
there we have the search feature again :D @johannchopin well, while the number of emojis is small, every time I use the site, I always do a |
That is similar to what I've implemented, |
Yeah, I would only not use the main |
so another separate file just for categorizing adding additional tags? with or without the tags prop, the current search feature is enough (for me) |
Really love this implementation shown in the gif. But there is 'only' 67 gitmojis. In most case I just scroll 1secs and find it. Writting the word will cost me more time I thing 😅. Moreover 80% of the users already have an idea for the emojis they search (since they already read all the gitmojis at least once). |
Well, we also have to think about the other 20%, :D |
I think Ctrl + F is enough. |
We can try to implement this but not on the header IMHO this should be placed on a "Toolbar" just below the header |
1653915
to
62f69eb
Compare
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/c4olryozs |
Description
I use Gitmoji everyday, and everytime I need to find the best emoji by a key word
I've added a search box to match the results that shown in the list
Demo
Tests
tests passed, but I've added a useContext store and I'm not sure how to test it