Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search emoji #411

Closed

Conversation

dorlugasigal
Copy link

@dorlugasigal dorlugasigal commented Feb 26, 2020

Description

I use Gitmoji everyday, and everytime I need to find the best emoji by a key word
I've added a search box to match the results that shown in the list

Demo

Tests

tests passed, but I've added a useContext store and I'm not sure how to test it

@dorlugasigal
Copy link
Author

i fixed a bug : on load there were no emojis

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 2, 2020

related to #405

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 2, 2020

there we have the search feature again :D @johannchopin

well, while the number of emojis is small, every time I use the site, I always do a ctrl+f on it, I think we could really benefit from having, not only the name-matching search, but also a related-match result, for exemple, when you search for "style" we could show 💄 💫 and 📱, just another thought :D

@dorlugasigal
Copy link
Author

dorlugasigal commented Jun 2, 2020

there we have the search feature again :D @johannchopin

well, while the number of emojis is small, every time I use the site, I always do a ctrl+f on it, I think we could really benefit from having, not only the name-matching search, but also a related-match result, for exemple, when you search for "style" we could show 💄 💫 and 📱, just another thought :D

That is similar to what I've implemented,
I made the search corresponding to the text of the icon, or the description.
In order to add what you suggest, we should add a "tag" property (or something) on each emoji. Right now I'm not sure how to categorize each one

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 2, 2020

there we have the search feature again :D @johannchopin
well, while the number of emojis is small, every time I use the site, I always do a ctrl+f on it, I think we could really benefit from having, not only the name-matching search, but also a related-match result, for exemple, when you search for "style" we could show lipstick dizzy and iphone, just another thought :D

That is similar to what I've implemented,
I made the search corresponding to the text of the icon, or the description.
In order to add what you suggest, we should add a "tag" property (or something) on each emoji. Right now I'm not sure how to categorize each one

Yeah, I would only not use the main gitmoji.json file for it, cuz it's information that not everyone will need (mainly this site).

@dorlugasigal
Copy link
Author

there we have the search feature again :D @johannchopin
well, while the number of emojis is small, every time I use the site, I always do a ctrl+f on it, I think we could really benefit from having, not only the name-matching search, but also a related-match result, for exemple, when you search for "style" we could show lipstick dizzy and iphone, just another thought :D

That is similar to what I've implemented,
I made the search corresponding to the text of the icon, or the description.
In order to add what you suggest, we should add a "tag" property (or something) on each emoji. Right now I'm not sure how to categorize each one

Yeah, I would only not use the main gitmoji.json file for it, cuz it's information that not everyone will need (mainly this site).

so another separate file just for categorizing adding additional tags?
i think that would be a bit too much to maintain..
in my opinion maybe adding a property to each emoji would be a better solution..

with or without the tags prop, the current search feature is enough (for me)

@johannchopin
Copy link
Collaborator

Really love this implementation shown in the gif. But there is 'only' 67 gitmojis. In most case I just scroll 1secs and find it. Writting the word will cost me more time I thing 😅. Moreover 80% of the users already have an idea for the emojis they search (since they already read all the gitmojis at least once).

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 2, 2020

Really love this implementation shown in the gif. But there is 'only' 67 gitmojis. In most case I just scroll 1secs and find it. Writting the word will cost me more time I thing . Moreover 80% of the users already have an idea for the emojis they search (since they already read all the gitmojis at least once).

Well, we also have to think about the other 20%, :D

@KaKi87
Copy link
Contributor

KaKi87 commented Jun 4, 2020

I think Ctrl + F is enough.

@carloscuesta
Copy link
Owner

We can try to implement this but not on the header IMHO this should be placed on a "Toolbar" just below the header

@carloscuesta carloscuesta force-pushed the master branch 3 times, most recently from 1653915 to 62f69eb Compare June 29, 2020 16:37
@vercel
Copy link

vercel bot commented Jun 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/c4olryozs
✅ Preview: https://gitmoji-git-fork-dorlugasigal-feature-search-emoji.carloscuesta.vercel.app

Repository owner locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants