-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add semver
property to the gitmojis
#692
✨ Add semver
property to the gitmojis
#692
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/mpuf5jfqs |
@elliot-nelson @gustavopch @frinyvonnick @vhoyer @carloscuesta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks good to me, let's just wait for the opinion of other people that participated on the issue before merging this 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sweet to me; let's just hit the nail on which semver to use which what emoji, but the implementation looks flawless in my opinion :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too 🎉
Closes: #429
Description
What?
This PR adds a
semver
property to each Gitmoji. Thesemver
property can be'major'
for breaking changes,'minor'
for new features,'patch'
for bugfixes/small improvements andnull
if the commit doesn't affect the version of the package.Why?
Gitmojis are too granular, and we need a higher level grouping to know what kind of effect does each gitmoji/commit have on the project, which is necessary to be able to automate the package publishing process and so on.
Right now, there are some third-party projects that try to do this grouping on their side, but because there is a big room of interpretation of each emoji, they are not consistent.
Things to keep in mind
Tests